Status

--
enhancement
VERIFIED FIXED
10 years ago
9 years ago

People

(Reporter: lhansen, Assigned: lhansen)

Tracking

unspecified
Bug Flags:
in-testsuite +

Details

Attachments

(1 attachment)

(Assignee)

Description

10 years ago
Created attachment 357411 [details] [diff] [review]
Patch

SyntaxError is in ES3, but missing from Tamarin (because the need for it has been slight, to say the least).  This patch reintroduces it.

SyntaxError is required by the run-time compiler.

The patch could be #ifdef'd by the presence of the run-time compiler, but it's a tiny amount of code and leaving it in brings us closer to ES3 in any case.
Attachment #357411 - Flags: review?(edwsmith)
(Assignee)

Updated

10 years ago
Blocks: 474014

Updated

10 years ago
Attachment #357411 - Flags: review?(edwsmith) → review+

Comment 1

10 years ago
Comment on attachment 357411 [details] [diff] [review]
Patch

i suppose we could have used this instead of VerifyError, but oh well, hindsight.

Comment 2

10 years ago
I think you'll also need to define SyntaxError in Error.as, no?  anyway, whats in the patch looks fine.
(Assignee)

Comment 3

10 years ago
(In reply to comment #2)
> I think you'll also need to define SyntaxError in Error.as, no?  anyway, whats
> in the patch looks fine.

Turns out it was already defined there!  And the class is defined in core already, of course.  I overstated the case for the fix.  All it does is make SyntaxError available to C++ code.
(Assignee)

Comment 4

10 years ago
redux changeset:   1311:e44005c69314
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED

Comment 5

9 years ago
SyntaxError tested in acceptance/ecma3/ErrorObject/e15_11_1.as as well as various files in acceptance/as3/Statements/Exceptions/
Status: RESOLVED → VERIFIED
Flags: in-testsuite?

Updated

9 years ago
Flags: in-testsuite? → in-testsuite+
You need to log in before you can comment on or make changes to this bug.