Closed
Bug 474024
Opened 16 years ago
Closed 16 years ago
Introduce SyntaxError
Categories
(Tamarin Graveyard :: Virtual Machine, enhancement)
Tamarin Graveyard
Virtual Machine
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: lhansen, Assigned: lhansen)
References
Details
Attachments
(1 file)
|
1.11 KB,
patch
|
edwsmith
:
review+
|
Details | Diff | Splinter Review |
SyntaxError is in ES3, but missing from Tamarin (because the need for it has been slight, to say the least). This patch reintroduces it.
SyntaxError is required by the run-time compiler.
The patch could be #ifdef'd by the presence of the run-time compiler, but it's a tiny amount of code and leaving it in brings us closer to ES3 in any case.
Attachment #357411 -
Flags: review?(edwsmith)
|
||
Updated•16 years ago
|
Attachment #357411 -
Flags: review?(edwsmith) → review+
|
|
||
Comment 1•16 years ago
|
||
Comment on attachment 357411 [details] [diff] [review]
Patch
i suppose we could have used this instead of VerifyError, but oh well, hindsight.
|
|
||
Comment 2•16 years ago
|
||
I think you'll also need to define SyntaxError in Error.as, no? anyway, whats in the patch looks fine.
|
Assignee | |
Comment 3•16 years ago
|
||
(In reply to comment #2)
> I think you'll also need to define SyntaxError in Error.as, no? anyway, whats
> in the patch looks fine.
Turns out it was already defined there! And the class is defined in core already, of course. I overstated the case for the fix. All it does is make SyntaxError available to C++ code.
|
|
Assignee | |
Comment 4•16 years ago
|
||
redux changeset: 1311:e44005c69314
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
||
Comment 5•16 years ago
|
||
SyntaxError tested in acceptance/ecma3/ErrorObject/e15_11_1.as as well as various files in acceptance/as3/Statements/Exceptions/
Status: RESOLVED → VERIFIED
Flags: in-testsuite?
|
|
||
Updated•16 years ago
|
Flags: in-testsuite? → in-testsuite+
You need to log in
before you can comment on or make changes to this bug.
Description
•