474092 - Path conversion correction for OS/2

Status: RESOLVED WONTFIX

(Core :: JavaScript Engine, defect)

Description

[Peter Weilbacher]

While investigating bug 426639 I stumbled on a missing XP_OS2 in js\src\js.cpp, in the function MakeAbsolutePathname(). I think the code is currently unused (bracketed by checks for NARCISSUS) so that's why it hasn't crept up as a problem before.

But in case someone needs to convert paths again somewhere else and copies this code, I think this should be corrected. (Or can that NARCISSUS stuff be removed?)

Comment 1

[Peter Weilbacher]

Attachment: patch

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 357471 [details] [diff] [review]
patch

I'm not sure if you wanted review on this, but it looks good.

Narcissus is JS-in-JS you can find it in js/narcissus, but it requires Spidermonkey to be built with -DNARCISSUS (which is how this code is built.

Comment 3

[Peter Weilbacher]

Thanks, Blake. I guess that's a configuration that nobody has built on OS/2, at least not recently...

Not sure what the procedure is to get this into JS, so would be best, if somebody else could take care of that.

Comment 4

[Serge Gautherie (:sgautherie)]

Comment on attachment 357471 [details] [diff] [review]
patch

File has moved to /js/src/shell/js.cpp ...

Comment 5

[Peter Weilbacher]

Attachment: patch v2

Updated to new file location, carried over review.

Comment 6

[Walter Meinl]

(In reply to comment #5)
> Created an attachment (id=358368) [details]
> patch v2
> 
> Updated to new file location, carried over review.

Peter, it seems that this isn't necessary anymore, js.cpp was screwed up, see bug473485 and http://hg.mozilla.org/mozilla-central/rev/5042081085b5
Somehow by a strange merge during Christmas time the #ifdef XP_WIN was put in an #ifdef XP_UNIX block, so it would have never been reached. It was removed by the checkin mentioned.

Comment 7

[Peter Weilbacher]

Yeah, this is now indeed obsolete. Unless someone else moves other stuff back around in there...