474116 - Clean up deprecated GTK symbols

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Arpad Borsos [:Swatinem]]

Attachment: clean up deprecated gtk symbols

Make gecko future proof by cleaning up deprecated GTK functions which may be removed completely in some future version of gtk.
This is mostly gobject stuff and should be available in gtk 2.10.
The patch does not regress reftests or mochitests for me (although both of them do not run very reliably even without this patch)
It should be run through the tryserver in any case to make sure it works correctly.

BTW: are there automated tests for gtkmozembed?

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

-  // XXX work around until I can get pink to figure out why
-  // tooltips vanish if they show up right at the origin of the
-  // cursor.
-  root_y += 10;

So we're not doing this anymore. It sounds like that will break things, according to this comment. So either test it and make sure it doesn't break tooltips, or just take this change out of the patch, or do it in a way which gives us a y-offset.

The rest of the patch looks fine.

Comment 2

[Arpad Borsos [:Swatinem]]

Tooltips work for me in Web Content and in TestGtkEmbed, however I'm not sure the code is hit at all.
Benjamin: As embedding module owner, can you help me get this code tested?

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

You can set a printf there to see if the code is hit at all.

If you're not sure what to do, I recommend just taking this change out of the patch.

Comment 4

[Arpad Borsos [:Swatinem]]

Attachment: clean up deprecated gtk symbols, v2

I was trying to use gdb breakpoints.
Patch now without that change.

Comment 5

[Benjamin Smedberg]

Comment on attachment 357644 [details] [diff] [review]
clean up deprecated gtk symbols, v2

r=me

I don't think we want this for 1.9.1

Comment 6

[Arpad Borsos [:Swatinem]]

Attachment: patch for checkin [Checkin: Comment 8]

(In reply to comment #5)
> I don't think we want this for 1.9.1

Then lets get this into m-c (or tryserver first). Patch ready for hg import.

Comment 7

[Phil Ringnalda (:philor)]

http://tinderbox.mozilla.org/showbuilds.cgi?tree=MozillaTry&maxdate=1232877753 certainly didn't object to it, though the unit test machines are more of a trial.

Comment 8

[Serge Gautherie (:sgautherie)]

Comment on attachment 358012 [details] [diff] [review]
patch for checkin
[Checkin: Comment 8]


http://hg.mozilla.org/mozilla-central/rev/ce7f39495675