SMTP passwords should always be saved

RESOLVED FIXED in Thunderbird 3.0b2

Status

MailNews Core
Networking: SMTP
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

Trunk
Thunderbird 3.0b2

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

6.66 KB, patch
Bienvenu
: review+
standard8
: superreview+
Details | Diff | Splinter Review
(Assignee)

Description

9 years ago
Created attachment 357648 [details] [diff] [review]
The fix

I had this patch in my tree as part of the password manager changes but discarded it from the original landing because I forgot it wasn't just tidy up.

Toolkit's password manager doesn't support session passwords. Additionally, as master password is now protecting the cache, we should be saving server passwords when the user requests us to.

Therefore we can drop the password protect cache preference checking in the SMTP prompt code.

I also did some tidy up in these functions - they were unnecessarily complicated, had unneeded checks and could be optimised slightly.
Attachment #357648 - Flags: superreview?(neil)
Attachment #357648 - Flags: review?(neil)

Updated

9 years ago
Attachment #357648 - Flags: superreview?(neil)
Attachment #357648 - Flags: superreview+
Attachment #357648 - Flags: review?(neil)
Attachment #357648 - Flags: review?(bienvenu)

Comment 1

9 years ago
Comment on attachment 357648 [details] [diff] [review]
The fix

>+    return GetPassword(aUsername);
aPassword, surely ;-)

Comment 2

9 years ago
I'll wait for Standard8 to address Neil's comment before applying the patch and running with it.
(Assignee)

Comment 3

9 years ago
Created attachment 357701 [details] [diff] [review]
The fix v2

Fixed Neil's comment.
Attachment #357648 - Attachment is obsolete: true
Attachment #357701 - Flags: superreview+
Attachment #357701 - Flags: review?(bienvenu)
Attachment #357648 - Flags: review?(bienvenu)

Updated

9 years ago
Attachment #357701 - Flags: review?(bienvenu) → review+
(Assignee)

Comment 4

9 years ago
Checked in: http://hg.mozilla.org/comm-central/rev/5ae254acdf1e
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1b3
Product: Core → MailNews Core
(Assignee)

Updated

9 years ago
Target Milestone: mozilla1.9.1b3 → Thunderbird 3.0b2
You need to log in before you can comment on or make changes to this bug.