474288 - SMTP passwords should always be saved

Status: RESOLVED FIXED

(MailNews Core :: Networking: SMTP, defect)

Description

[Mark Banner (:standard8)]

Attachment: The fix

I had this patch in my tree as part of the password manager changes but discarded it from the original landing because I forgot it wasn't just tidy up.

Toolkit's password manager doesn't support session passwords. Additionally, as master password is now protecting the cache, we should be saving server passwords when the user requests us to.

Therefore we can drop the password protect cache preference checking in the SMTP prompt code.

I also did some tidy up in these functions - they were unnecessarily complicated, had unneeded checks and could be optimised slightly.

Comment 1

[[e-mail]]

Comment on attachment 357648 [details] [diff] [review]
The fix

>+    return GetPassword(aUsername);
aPassword, surely ;-)

Comment 2

[David :Bienvenu]

I'll wait for Standard8 to address Neil's comment before applying the patch and running with it.

Comment 3

[Mark Banner (:standard8)]

Attachment: The fix v2

Fixed Neil's comment.

Comment 4

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/5ae254acdf1e