474296 - Remove UA define of "WinNT3.51" and "WinNT4.0" due to out of support

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect)

Description

[Makoto Kato [:m_kato]]

Although the latest code doesn't support WinNT 3.51 and WinNT 4.0, there is still the following define for User-Agent.  We should remove it.


mozilla/netwerk/protocol/http/src/nsHttpHandler.cpp 

674             if (info.dwMajorVersion      == 3)
675                 mOscpu.AssignLiteral("WinNT3.51");
676             else if (info.dwMajorVersion == 4)
677                 mOscpu.AssignLiteral("WinNT4.0");

Comment 1

[Makoto Kato [:m_kato]]

Attachment: patch Av1

Comment 2

[Boris Zbarsky [:bzbarsky]]

I'm probably the wrong reviewer for this code.  I'm not sure who the right one is.

Comment 3

[Benjamin Smedberg]

Comment on attachment 362684 [details] [diff] [review]
patch Av1

seems like silly makework to me... what about the block below which is for win95/98/ME which we no longer support either? This code isn't hurting anybody, let's leave it alone?

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 362684 [details] [diff] [review]
patch Av1

per comment 3.

Comment 5

[Serge Gautherie (:sgautherie)]

(In reply to comment #3)
> what about the block below which is for
> win95/98/ME which we no longer support either?

Remove it too.

> This code isn't hurting anybody, let's leave it alone?

Dead code removal...

Comment 6

[Serge Gautherie (:sgautherie)]

Attachment: (Av2) WNTv4 and (all) older [Checkin: Comment 7]

Av1, with comment 3 suggestion(s),
and some more.

Comment 7

[Serge Gautherie (:sgautherie)]

Comment on attachment 390787 [details] [diff] [review]
(Av2) WNTv4 and (all) older
[Checkin: Comment 7]


http://hg.mozilla.org/mozilla-central/rev/ae4a2a49fff3