474320 - Additional variables for Mail Notification template

Status: RESOLVED WORKSFORME

(Bugzilla :: Email Notifications, enhancement)

Description

[misc]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.5) Gecko/2008120122 Firefox/3.0.5
Build Identifier: Latest CVS as of 2009-01-19

Many of the bug fields are available for use in the Mail Notification template (newchangedmail.txt.tmpl), but some are missing.

Below shows context diff with the ones I have added to my install and would like added upstream to official source.

Thanks.

Index: Bugzilla/BugMail.pm
===================================================================
RCS file: /cvsroot/mozilla/webtools/bugzilla/Bugzilla/BugMail.pm,v
retrieving revision 1.124
diff -c -r1.124 BugMail.pm
*** Bugzilla/BugMail.pm 1 Jan 2009 23:24:38 -0000       1.124
--- Bugzilla/BugMail.pm 19 Jan 2009 17:35:34 -0000
***************
*** 662,667 ****
--- 662,671 ----
          changername => $values{'changername'},
          reporter => $values{'reporter'},
          reportername => Bugzilla::User->new({name => $values{'reporter'}})->name,
+         qacontact => $values{'qa_contact'},
+         qacontactname => Bugzilla::User->new({name => $values{'qacontact'}})->name,
+         cc => $values{'cc'},
+         resolution => $values{'resolution'},
          diffs => $diffs,
          threadingmarker => build_thread_marker($id, $user->id, $isnew),
      };



Reproducible: Always

Steps to Reproduce:
1. Attempt to use in newchangedmail.txt.tmpl : qacontact, cc, resolution, etc.
2.
3.
Actual Results:  
null

Expected Results:  
Replacement of template token with actual value from bug

Comment 1

[Tyler Downer [He/Him]]

Please attach patches as an attachment.

Comment 2

[misc]

Attachment: Patch to 3.0.3 BugMail.pm to create additional variables for newchangedmail.txt.tmpl

This is the patch I am currently using with my 3.0.3 Bugzilla install.

Comment 3

[misc]

Attachment: (Proposed) Patch to *latest* BugMail.pm to create additional variables for newchangedmail.txt.tmpl

I have created a patch that would apply to the latest BugMail.pm file.
I have not tested this as I only have a 3.0.3 install.

Comment 4

[Max Kanat-Alexander]

Really we should just be passing bug objects to the template...

Comment 5

[Frédéric Buclin]

We don't need more variables passed to the email template. Bugzilla 3.8 now pass the bug object directly, see bug 395451.