Closed Bug 474322 Opened 11 years ago Closed 11 years ago

[mozmill] Add tests for default alarms

Categories

(Calendar :: Internal Components, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Fallen, Assigned: Fallen)

Details

Attachments

(1 file)

Attached patch Alarm test - v1 β€” β€” Splinter Review
This is the first mozmill test for calendar thats going for the tree. I'd like to get some first tests checked in even though mozmill is not integrated into the build system yet.

This test covers part of https://litmus.mozilla.org/show_test.cgi?id=2510 up to the point where we test if the event dialog shows the alarms in the dialog when creating a new event.

This test currently fails due to a calendar bug that will be fixed with my alarm bugs. To make this test temporarily succeed, change "task" of "50 days before the task starts" to "event".
Attachment #357695 - Flags: review?(mschroeder)
Comment on attachment 357695 [details] [diff] [review]
Alarm test - v1

Clint, if you have time for this before Martin does, feel free to review :-)
Attachment #357695 - Flags: review?(ctalbert)
I don't feel well by the dependency to bug 457265. We will have a lot of tests which depend on the MozMill build system integration and we cannot add each of those as dependency. I'll remove the dependency for now.
No longer depends on: 457265
Comment on attachment 357695 [details] [diff] [review]
Alarm test - v1

Philipp, this is a very nicely written test.  It looks good to me.  The only nit I have is that it would be good for you to include a comment in the test somewhere that references the Litmus test you are working from.  That way when we add in support for metadata on tests, we can associate this test with the corresponding litmus testcase.
Attachment #357695 - Flags: review?(ctalbert) → review+
Comment on attachment 357695 [details] [diff] [review]
Alarm test - v1

>+  mailController.click(new elementslib.ID(mailController.window.document, "menu_Edit"));
>+  mailController.click(new elementslib.ID(mailController.window.document, "menu_preferences"));

We should have a better way to achieve that in one step. The new menuAPI supports ids too now. I wait for an example of Mikeal in bug 473829.
Attachment #357695 - Flags: review?(mschroeder)
I'll move to the menu api later on, keeping it this way for now.

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/dc3da0605227>

-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.0
These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".
Target Milestone: 1.0 → 1.0b1
You need to log in before you can comment on or make changes to this bug.