Closed Bug 474366 Opened 13 years ago Closed 13 years ago

OS/2 build break due to bug470914

Categories

(Core :: XPConnect, defect)

x86
OS/2
defect
Not set
major

Tracking

()

RESOLVED FIXED

People

(Reporter: wuno, Assigned: wuno)

References

Details

(Keywords: fixed1.9.1)

Attachments

(2 files, 2 obsolete files)

User-Agent:       Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.9.2a1pre) Gecko/20090120 Minefield/3.2a1pre
Build Identifier: 

E:/usr/src/hg/mozilla-central/js/src/xpconnect/shell/xpcshell.cpp: In function 'JSBool GetLocationProperty(JSContext*, JSObject*, jsval, jsval*)':
E:/usr/src/hg/mozilla-central/js/src/xpconnect/shell/xpcshell.cpp:130: error: expected ';' before 'JSStackFrame'
E:/usr/src/hg/mozilla-central/js/src/xpconnect/shell/xpcshell.cpp:168: error: 'filenameString' was not declared in this scope
E:/usr/src/hg/mozilla-central/js/src/xpconnect/shell/xpcshell.cpp:176: error: 'filenameString' was not declared in this scope
E:/usr/src/hg/mozilla-central/js/src/xpconnect/shell/xpcshell.cpp: In function 'JSBool GC(JSContext*, JSObject*, uintN, jsval*, jsval*)':
E:/usr/src/hg/mozilla-central/js/src/xpconnect/shell/xpcshell.cpp:506: warning: format '%08lx' expects type 'long unsigned int', but argument 5 has type 'int'
make.exe[5]: *** [xpcshell.o] Error 1


Reproducible: Always

Steps to Reproduce:
1.
2.
3.
Blocks: 470914
Version: unspecified → Trunk
Just an unbreaker for the moment
Oops, sorry. It was my intention that the code should build on all platforms, and just return early out of all those methods.
(In reply to comment #2)
> Oops, sorry. It was my intention that the code should build on all platforms,
> and just return early out of all those methods.
Ted, I think this would really keep out unsupported platforms
Assignee: nobody → wuno
Attachment #357742 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #358288 - Flags: review?(ted.mielczarek)
Comment on attachment 358288 [details] [diff] [review]
really exclude unsupported platforms

Can you update this to take attachment 358017 [details] [diff] [review] into account? (Follow-up patch on bug 470914 to fix WinCE.)
Attachment #358288 - Flags: review?(ted.mielczarek)
(In reply to comment #4)
> (From update of attachment 358288 [details] [diff] [review])
> Can you update this to take attachment 358017 [details] [diff] [review] into account? (Follow-up patch on
> bug 470914 to fix WinCE.)
Oops, thought that the WinCE probs were already solved by this checkin
Attachment #358288 - Attachment is obsolete: true
Attachment #358476 - Flags: review?(ted.mielczarek)
Attachment #358476 - Flags: review?(ted.mielczarek) → review+
Keywords: checkin-needed
Pushed <http://hg.mozilla.org/mozilla-central/rev/1f7c2d158994>. This was only needed on trunk, right?
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
(In reply to comment #4)
> (From update of attachment 358288 [details] [diff] [review])
> Can you update this to take attachment 358017 [details] [diff] [review] into account? (Follow-up patch on
> bug 470914 to fix WinCE.)

Ted, Peter, looking again at attachment 358017 [details] [diff] [review] I realized that I should have put some brackets around #if !not defined(XP_WIN) && !not defined(XP_UNIX) before || defined (WINCE) as it was done in that attachment.
the fix here takes in account that attachment 358476 [details] [diff] [review] was already pushed, thanks Peter.
And yes so far the fix is only needed for trunk
Attachment #359796 - Flags: review?(ted.mielczarek)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attachment #359796 - Flags: review?(ted.mielczarek) → review+
Comment on attachment 359796 [details] [diff] [review]
doo,  missed some brackets (checked in: comment 9)

I think order-of-operations binds it this way anyway, but doesn't hurt to make it explicit, certainly.
Keywords: checkin-needed
Whiteboard: attachment 359796
Yeah, doesn't really change anything, but pushed for clarity:
http://hg.mozilla.org/mozilla-central/rev/2cd22042f7ef
Status: REOPENED → RESOLVED
Closed: 13 years ago13 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: attachment 359796
Attachment #359796 - Attachment description: doo, missed some brackets → doo, missed some brackets (checked in: comment 9)
Attachment #358476 - Attachment description: really exclude unsupported platforms including WINCE → really exclude unsupported platforms including WINCE (checked in: comment 6)
(In reply to comment #6)
> Pushed <http://hg.mozilla.org/mozilla-central/rev/1f7c2d158994>. This was only
> needed on trunk, right?

(In reply to comment #9)
> Yeah, doesn't really change anything, but pushed for clarity:
> http://hg.mozilla.org/mozilla-central/rev/2cd22042f7ef
Peter, these patches are needed now also for the 1.9.1 branch, see bug470914 comment #26.
in bug470914 #23 Ted says no approval is needed for xpcshell.
You need to log in before you can comment on or make changes to this bug.