Closed
Bug 474393
Opened 15 years ago
Closed 15 years ago
nsChannelToPipeListener passes incorrect values to UpdateBytesDownloaded
Categories
(Core :: Audio/Video, defect, P2)
Core
Audio/Video
Tracking
()
RESOLVED
FIXED
People
(Reporter: roc, Assigned: roc)
Details
(Keywords: fixed1.9.1)
Attachments
(1 file)
1.81 KB,
patch
|
cajbir
:
review+
|
Details | Diff | Splinter Review |
There's an obvious bug where if a single OnDataAvailable is split into several calls to write to the pipe, we call UpdateBytesDownloaded with the wrong total number of bytes for all writes after the first. I think we should land a fix for that now, even though this code is going to change in bug 455654, because I want to see if it fixes test_progress1.html, and if it does (or even if it doesn't) we should fix this ASAP.
Flags: blocking1.9.1+
Attachment #357768 -
Flags: review?(chris.double)
Updated•15 years ago
|
Attachment #357768 -
Flags: review?(chris.double) → review+
Assignee | ||
Updated•15 years ago
|
Priority: -- → P2
Assignee | ||
Updated•15 years ago
|
Whiteboard: [needs landing]
Assignee | ||
Comment 1•15 years ago
|
||
Pushed http://hg.mozilla.org/mozilla-central/rev/ed4a08325d3c with the bug fix and http://hg.mozilla.org/mozilla-central/rev/5ab96ef362ae to reenable test_progress1.html.
Status: NEW → ASSIGNED
Whiteboard: [needs landing]
Assignee | ||
Comment 2•15 years ago
|
||
I checked in the bug fix and reenabled test_progress1, but test_progress1 is still failing from time to time on Linux so I turned it off again :-(. It never failed on Mac or Windows.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•15 years ago
|
Whiteboard: [needs 191 landing]
Assignee | ||
Comment 3•15 years ago
|
||
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/020d7b7fc72b
Keywords: fixed1.9.1
Whiteboard: [needs 191 landing]
You need to log in
before you can comment on or make changes to this bug.
Description
•