nsChannelToPipeListener passes incorrect values to UpdateBytesDownloaded

RESOLVED FIXED

Status

()

Core
Audio/Video
P2
normal
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: roc, Assigned: roc)

Tracking

({fixed1.9.1})

Trunk
fixed1.9.1
Points:
---
Bug Flags:
blocking1.9.1 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 357768 [details] [diff] [review]
fix

There's an obvious bug where if a single OnDataAvailable is split into several calls to write to the pipe, we call UpdateBytesDownloaded with the wrong total number of bytes for all writes after the first. I think we should land a fix for that now, even though this code is going to change in bug 455654, because I want to see if it fixes test_progress1.html, and if it does (or even if it doesn't) we should fix this ASAP.
Flags: blocking1.9.1+
Attachment #357768 - Flags: review?(chris.double)

Updated

9 years ago
Attachment #357768 - Flags: review?(chris.double) → review+
Priority: -- → P2
Whiteboard: [needs landing]
Pushed http://hg.mozilla.org/mozilla-central/rev/ed4a08325d3c with the bug fix and http://hg.mozilla.org/mozilla-central/rev/5ab96ef362ae to reenable test_progress1.html.
Status: NEW → ASSIGNED
Whiteboard: [needs landing]
I checked in the bug fix and reenabled test_progress1, but test_progress1 is still failing from time to time on Linux so I turned it off again :-(. It never failed on Mac or Windows.
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Whiteboard: [needs 191 landing]
You need to log in before you can comment on or make changes to this bug.