47441 - [patch] Classic skin scrollbars mis-coloured on Windows

Status: VERIFIED FIXED

(SeaMonkey :: Themes, defect, P3)

Description

[Antony Mawer]

The scrollbars in the Classic skin on Windows (build 2000080120) appear a 
brighter off-looking colour than the other Windows scrollbars. I had a look 
through the XUL files and checked up the CSS2 spec, and it turns out the XUL was 
using the scrollbar background colour for the actual scroll bar slider and thumb 
buttons. Below is a diff to rectify it so that the appearance is consistent with 
the default Windows scrollbar appearance.


RCS file: /cvsroot/mozilla/themes/classic/global/win/scrollbars.css,v
retrieving revision 1.4
diff -r1.4 scrollbars.css
31c31
<     background-color      : scrollbar;
---
>     background-color      : threedface;
59c59
<     background-color      : scrollbar;
---
>     background-color      : threedface;
127d126
<     background-image      : 
url("chrome://global/skin/scrollbar-slider-bg.gif");

Comment 1

[Antony Mawer]

Attachment: wait, i figured out how to attach things. i'm an idiot, here's the diff.

Comment 2

[[e-mail]]

Actually, Windows no longer draws anything in the scrollbar colour...

Comment 3

[Antony Mawer]

Interesting. I make a number of screen captures of scrollbars around the place, 
and as far as I could tell with these changes the Mozilla scrollbars matched 
those used throughout other Windows programs using native Windows widgets. hrmm.

Comment 4

[[e-mail]]

Sorry, I misread the diff - you had deleted the slider's background-color: 
scrollbar whereas with the thumb and arrow boxes you had changed the colour to 
threedface. I'm not sure what colour the slider will use if none is specified.

Comment 5

[Antony Mawer]

Well, a basic synopsis of what the patch does:

* Change colour of the thumb buttons from 'scrollbar' to 'threedface'
* Change colour of the scrollbar button from 'scrollbar' to 'threedface'
* Removal of image (a 2x2 pixel gif, alternating white-grey) from the slider

According to the CSS2 spec, the system colour "scrollbar" is defined as:

"Scrollbar: Scroll bar gray area."

In otherwords, the background area of the scrollbar (or at least this is my 
interpretation, and it's appearance appears to concur with this 
interpretation). The relevant part of the specification can be found at 
http://www.w3.org/TR/REC-CSS2/ui.html#system-colors

The image used on the "gray area" of the scrollbars is not needed, as this area 
is painted with a solid colour, not a dithered bitmap; hence the removal of the 
background-image.

Comment 6

[Ian Tommins ('thelem')]

I know ben doesn't want other people 'messing up' the classic skin, so I have 
reassigned to him and put hangus on CC.

Comment 7

[Antony Mawer]

After the possibility crept to mind that the scrollbars probably would have 
matched when the skin was created, I poked around to work out why they looked 
off-coloured (requiring the patch to look right) for me. As I'd suspected...

If the colour scheme in use is something along the lines of the Windows 
Standard theme (that is, using that ugly default grey for 3d objects ;), the 
scrollbars appear only the very slightest bit difference, virtually 
indistinguishable from normal scrollbars. If, however, the 3d object colour is 
changed (as in my case, where it's R142 G159 B176, the problem manifests itself 
in the form of ugly-coloured scrollbars.

Just thought it might help in showing why this patch is needed; for those of 
you with standard Windows colours you quite possibly may not have noticed it.

Comment 8

[Ben Goodger (use ben at mozilla dot org for email)]

fixed. 

Comment 9

[Matthew Mastracci]

I think there's one last thing to fix.  The color surrounding the scrollbar 
button when pressed should be threedface, not scrollbar.  I don't have a diff, 
but here is the relevant change to the css file:

scrollbarbutton:hover:active > .scrollbarbutton-box
  {
    border                : 1px solid threedface;
    padding               : 2px 0px 0px 2px;
  } 

Comment 10

[Ben Goodger (use ben at mozilla dot org for email)]

reopening so I can investigate...

Comment 11

[Antony Mawer]

Browsing the source tree, it appears this problem has not been fixed. v1.5 of 
scrollbar.css shows the background-color of the slider being changed 
to 'threedface' from 'scrollbar' -- the correct setting for this is in 
fact 'scrollbar', as this is the scrollbar grey area. Additionally, the thumb 
and scrollbar buttons background colour have not being changed. The relevant 
changed parts of v1.5 of scrollbar.css are:


; Thumb butttons
 24 thumb 
 25   {
 26     behavior              : url
(chrome://global/skin/classicBindings.xml#thumb);
 27     border-left           : 1px solid threedface;
 28     border-top            : 1px solid threedface;
 29     border-right          : 1px solid threeddarkshadow;
 30     border-bottom         : 1px solid threeddarkshadow;
 31     background-color      : threedface;
 32   }

; Scrollbar button

 51 scrollbarbutton 
 52   {
 53     behavior              : url
("chrome://global/skin/classicBindings.xml#scrollbarbutton");
 54     cursor                : default;
 55     border-left           : 1px solid threedface;
 56     border-top            : 1px solid threedface;
 57     border-right          : 1px solid threeddarkshadow;
 58     border-bottom         : 1px solid threeddarkshadow;
 59     background-color      : threedface;
 60   }

; Slider (background area of scrollbar.. note removal of bgimage!)
124 slider 
125   {
126     background-color      : scrollbar;
128   }

Comment 12

[leger]

Adding classic keyword

Comment 13

[Stephen Koren]

*** Bug 48717 has been marked as a duplicate of this bug. ***

Comment 14

[Paul Wyskoczka]

Updating QA Contact to [e-mail]

Comment 15

[Joe Hewitt (gone)]

I use a different color scheme from the default, and this bug is really 
apparent to me.  Annoying in fact.  This is a super easy fix.  Want me to take 
this, Ben?

Comment 16

[Joe Hewitt (gone)]

I've just checked in a fix for this. 

Comment 17

[Blake Ross]

marking fixed per Joe's comment.

Comment 18

[Keyser Sose]

Works for Me
Platform: PC
OS: Windows 98
Mozilla Version: 2000100508

Marking as Verified