Closed Bug 474441 Opened 13 years ago Closed 13 years ago

Move the marquee reftests into the marquee reftests folder

Categories

(Core :: Layout, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: martijn.martijn, Assigned: martijn.martijn)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch patch (obsolete) — Splinter Review
There are some reftests that test marquees in the bugs subfolder.

I think it makes sense to move those in the marquee folder.
That way, when you make changes to the xbl-marquee.xml file (the marquee binding file), you can easily test those by doing only the tests in that folder.

Good idea or bad idea?
Attachment #357804 - Flags: review?(bzbarsky)
Comment on attachment 357804 [details] [diff] [review]
patch

Sounds fine.  I assume you did an hg move or whatever on those files, right?
Attachment #357804 - Flags: review?(bzbarsky) → review+
(In reply to comment #1)
> (From update of attachment 357804 [details] [diff] [review])
> Sounds fine.  I assume you did an hg move or whatever on those files, right?

I did an hg addremove or isn't that good?
Yeah, that's fine.
NO, IT'S NOT!  You need to do hg move.
(Note that these are git-format diffs, so if it were a proper move, the diff would show that it was a move rather than an add + remove.)
Doh.  That's what made me ask in the first place, but I seemed to recall some docs somewhere claiming that addremove and move did the same thing in simple cases.
Attached patch patch2Splinter Review
Ok, I did an hg rename now this time.
Attachment #357804 - Attachment is obsolete: true
Attachment #357931 - Flags: review?(dbaron)
Comment on attachment 357931 [details] [diff] [review]
patch2

r=dbaron
Attachment #357931 - Flags: review?(dbaron) → review+
Component: Reftest → Layout: Misc Code
OS: Windows XP → All
Product: Testing → Core
QA Contact: reftest → layout.misc-code
Hardware: x86 → All
Assignee: nobody → martijn.martijn
Checked in:
$ hg tip
changeset:   24065:14a00e1bdfc2
tag:         qtip
tag:         tip
tag:         qbase
tag:         marqueetests2.diff
user:        Martijn Wargers <mwargers@mozilla.com>
date:        Thu Jan 22 17:30:28 2009 +0100
summary:     imported patch marqueetests2.diff

Sorry for the useless commit message.
Status: NEW → RESOLVED
Closed: 13 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Sorry, apparently I haven't checked it in yet.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Ok, now it's really checked in:
$ hg tip
changeset:   24065:4f398c5824e1
tag:         tip
user:        Martijn Wargers <mwargers@mozilla.com>
date:        Thu Jan 22 18:12:27 2009 +0100
summary:     Bug 474441 - Move the marquee reftests into the marquee reftests fo
lder, r=dbaron

Notes to self, I did:
hg qimport marqueetests2.diff
hg qpush
hg qrefresh -e (to edit the commit message)
hg qdel -r qtip (to change it into a "real" changeset)

http://hg.mozilla.org/mozilla-central/rev/4f398c5824e1 is confusing, but in reality still a hove was done.
Status: REOPENED → RESOLVED
Closed: 13 years ago13 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
Component: Layout: Misc Code → Layout
Product: Core Graveyard → Core
You need to log in before you can comment on or make changes to this bug.