474441 - Move the marquee reftests into the marquee reftests folder

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Martijn Wargers (dead)]

Attachment: patch

There are some reftests that test marquees in the bugs subfolder.

I think it makes sense to move those in the marquee folder.
That way, when you make changes to the xbl-marquee.xml file (the marquee binding file), you can easily test those by doing only the tests in that folder.

Good idea or bad idea?

Comment 1

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 357804 [details] [diff] [review]
patch

Sounds fine.  I assume you did an hg move or whatever on those files, right?

Comment 2

[Martijn Wargers (dead)]

(In reply to comment #1)
> (From update of attachment 357804 [details] [diff] [review])
> Sounds fine.  I assume you did an hg move or whatever on those files, right?

I did an hg addremove or isn't that good?

Comment 3

[Boris Zbarsky [:bzbarsky]]

Yeah, that's fine.

Comment 4

[David Baron :dbaron:]

NO, IT'S NOT!  You need to do hg move.

Comment 5

[David Baron :dbaron:]

(Note that these are git-format diffs, so if it were a proper move, the diff would show that it was a move rather than an add + remove.)

Comment 6

[Boris Zbarsky [:bzbarsky]]

Doh.  That's what made me ask in the first place, but I seemed to recall some docs somewhere claiming that addremove and move did the same thing in simple cases.

Comment 7

[Martijn Wargers (dead)]

Attachment: patch2

Ok, I did an hg rename now this time.

Comment 8

[David Baron :dbaron:]

Comment on attachment 357931 [details] [diff] [review]
patch2

r=dbaron

Comment 9

[Martijn Wargers (dead)]

Checked in:
$ hg tip
changeset:   24065:14a00e1bdfc2
tag:         qtip
tag:         tip
tag:         qbase
tag:         marqueetests2.diff
user:        Martijn Wargers <[e-mail]>
date:        Thu Jan 22 17:30:28 2009 +0100
summary:     imported patch marqueetests2.diff

Sorry for the useless commit message.

Comment 10

[Martijn Wargers (dead)]

Sorry, apparently I haven't checked it in yet.

Comment 11

[Martijn Wargers (dead)]

Ok, now it's really checked in:
$ hg tip
changeset:   24065:4f398c5824e1
tag:         tip
user:        Martijn Wargers <[e-mail]>
date:        Thu Jan 22 18:12:27 2009 +0100
summary:     Bug 474441 - Move the marquee reftests into the marquee reftests fo
lder, r=dbaron

Notes to self, I did:
hg qimport marqueetests2.diff
hg qpush
hg qrefresh -e (to edit the commit message)
hg qdel -r qtip (to change it into a "real" changeset)

http://hg.mozilla.org/mozilla-central/rev/4f398c5824e1 is confusing, but in reality still a hove was done.