LIR needs to mark dxns live in epilogue

NEW
Unassigned

Status

Tamarin
Baseline JIT (CodegenLIR)
9 years ago
7 years ago

People

(Reporter: Steven Johnson, Unassigned)

Tracking

unspecified
Future
Bug Flags:
in-testsuite ?
flashplayer-needsbackport -
flashplayer-qrb +
flashplayer-triage +

Details

(Whiteboard: needs-test-case, loose-end)

Attachments

(1 attachment)

(Reporter)

Description

9 years ago
Created attachment 357816 [details] [diff] [review]
Patch

dxns wasn't being kept live, so in some situations it was being recycled for other temp storage, causing havok in code that used E4X defaultXmlNamespace.
Attachment #357816 - Flags: review?(edwsmith)

Updated

9 years ago
Attachment #357816 - Flags: review?(edwsmith) → review+

Comment 1

9 years ago
test case needed before closing the bug
(Reporter)

Comment 2

9 years ago
agreed -- haven't seen it in avmshell, bug was found in Flash integration

Updated

9 years ago
Flags: in-testsuite?
(Reporter)

Comment 3

9 years ago
pushed to redux as changeset:   1318:828ce1fdff63

Updated

9 years ago
Flags: flashplayer-triage+
Flags: flashplayer-qrb?

Comment 4

9 years ago
Steven, can this be closed?
(Reporter)

Comment 5

9 years ago
Edwin suggested we keep it open until we can come up with a testcase  that actually tests it in avmshell (as opposed to Flash)

Comment 6

9 years ago
Ooohhhh.... the new assembler to the rescue?

Updated

9 years ago
Flags: flashplayer-qrb? → flashplayer-qrb+
Priority: -- → P3
Target Milestone: --- → flash10.x

Updated

8 years ago
Priority: P3 → --
Target Milestone: flash10.1 → Future

Updated

8 years ago
Whiteboard: Needs TC

Updated

8 years ago
Component: Virtual Machine → JIT Compiler (NanoJIT)

Updated

7 years ago
Whiteboard: Needs TC → needs-test-case

Comment 7

7 years ago
How to add the requested test case? Can the assembler help with this?
Assignee: stejohns → nobody
Flags: flashplayer-needsbackport-
Whiteboard: needs-test-case → needs-test-case, loose-end

Comment 8

7 years ago
If the offending function in a SWF can be found, then it can be isolated and compiled with ABC.  Or, a selftest-style test case can be written that analyzes the LIR via brute force.
You need to log in before you can comment on or make changes to this bug.