Closed Bug 474461 Opened 14 years ago Closed 14 years ago

l10n afterpush builds incorrectly reported as testfailed status

Categories

(MailNews Core :: Build Config, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0b3

People

(Reporter: stef, Assigned: standard8)

References

Details

Attachments

(2 files)

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; pl; rv:1.9.1b2) Gecko/20081201 Firefox/3.1b2
Build Identifier: 

Don't know if this is the same problem as in bug 465585 but iirc some time ago afterpush builds and nightly ones were different in that case.

If I push sth to hg, new set of builds will be generated - even if all strings are ok, the build status will be "testfailed".

Reproducible: Always
Blocks: 470669
Depends on: 477384
We've just improved the situation for those locales that do ship with dictionaries (by fixing bug 477384), for those that don't, we still have an issue. There is probably a simple fix, but we'll have to do some detection. I'll put this on my plate to look at after beta 3 (unless someone grabs it off me before then).
Assignee: nobody → bugzilla
Status: UNCONFIRMED → NEW
Component: Server Operations → Build Config
Ever confirmed: true
Product: Mozilla Messaging → Thunderbird
QA Contact: server-ops → build-config
Target Milestone: --- → Thunderbird 3.0b3
Version: other → Trunk
Flags: wanted-thunderbird3+
Product: Thunderbird → MailNews Core
QA Contact: build-config → build-config
(In reply to comment #1)
> We've just improved the situation for those locales that do ship with
> dictionaries (by fixing bug 477384)

v. with pl.
Here's the proposed fix. As having no dictionaries is valid for some locales we shouldn't warn about it. Therefore change the build so that we don't zip dictionaries/ if it isn't found.

We could change buildbot not to warn about extra output in that step, but I think that could be dangerous (locales not knowing about real warnings), so I think we should do this build config change.

If this is accepted and works, I'll do a patch for Sunbird & SeaMonkey as well.
Attachment #361518 - Flags: review?(kairo)
Comment on attachment 361518 [details] [diff] [review]
[checked in] Proposed Fix

From code inspection and without doing actual testing, this looks OK for me, and we probably should tell Axel what we're doing here as Firefox has the same thing probably.
Attachment #361518 - Flags: review?(kairo) → review+
We don't have the problem, as for Firefox, none of defaults, dictionaries, searchplugins is considered to be part of the language pack. It's just chrome and the admin files for the extension.
Comment on attachment 361518 [details] [diff] [review]
[checked in] Proposed Fix

This is now checked in, I'll do a straw poll after tomorrow's l10n builds and see if it has worked.
Attachment #361518 - Attachment description: Proposed Fix → [checked in] Proposed Fix
The Thunderbird fix seems to have stuck, so this fixes calendar and suite in the same way.
Attachment #362869 - Flags: review?(kairo)
Comment on attachment 362869 [details] [diff] [review]
[checked in] Fix calendar and suite

Thanks for the patch!
Attachment #362869 - Flags: review?(kairo) → review+
Comment on attachment 362869 [details] [diff] [review]
[checked in] Fix calendar and suite

This is checked in as well now. http://hg.mozilla.org/comm-central/rev/4be98d27a58a
Attachment #362869 - Attachment description: Fix calendar and suite → [checked in] Fix calendar and suite
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.