474531 - WinCE mozce_shunt.dll copying produces corrupt DLL

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[John Wolfe (:wolfe)]

Copying the mozce_shunt.dll into the appropriate DIST directories produces a mozce_shunt.dll file which has been corrupted.

Specifically, 117 bytes into the file, the following sequence:

0x0D 0x0D 0x0A 0x24

is replaced with the sequence:

0x0A 0x0A 0x24

Unfortunately, randomly replacing contents of a binary executable file is BAD.

I believe it may be a failure of "ASCII copy" verses "Binary Copy", as the sequence 0x0D 0x0A is a CR-LF, which in ascii copy is sometimes replaced with 0x0A (LF).

Perhaps nsinstall is called with bad arguments?

Comment 1

[John Wolfe (:wolfe)]

Attachment: v1.0 patch

Commented out DIST_FILES - otherwise seems to work on my initial tests.

Comment 2

[John Wolfe (:wolfe)]

Comment on attachment 357905 [details] [diff] [review]
v1.0 patch

blassey suggested that this should be reviewed by ted.

Ted, this is a modification to a patch file that blassey is working on (named "tools_refactor") which is an uber-collection of all the various modifications to the wince build tools that are waiting to land.

BUT, this modification causes the binary file mozce_shunt.dll to be copied into the DIST directory - we might want to copy into the DIST bin directory instead.

Comment 3

[(not currently active) Ted Mielczarek]

Comment on attachment 357905 [details] [diff] [review]
v1.0 patch

Yeah, files in DIST_FILES get run through the preprocessor, which is not at all what you want. It looks like blassey's rollup patch does this the right way, so I'm going to deal with it in bug 474737, ok?

Comment 4

[John Wolfe (:wolfe)]

Fixed by bug 474737.