47458 - wrong icon for bookmark folders in sidebar

Status: VERIFIED FIXED

(SeaMonkey :: Bookmarks & History, defect, P3)

Description

[Jilles van Gurp]

The same icon is used for both bookmarks and folders in my imported bookmarks
(from IE). This is a bit annoying since that makes it harder to glance through
the bookmarks.

Comment 1

[Claudius Gayle]

confirmed with 2000080204 builds. Note, this is a little more than a mere annoyance. The wrong icon is being used for a closed 
folder within the IE favorites folder. SO you have a little triangle pointing to a globe. When you click to open the folder it changes 
to the correct open folder icon.

Comment 2

[Tobias Burnus]

Note: This is not only the case in the sidebar, but also in the Bookmark window.
Moreover I *do* get this not only for imported bookmarks from IE (I don't have
it), but also from a bookmark.html copied from NS 4.7x. If I click on the
folder, it opens and shows the correct icon. (This problem is independed of the
theme).
2000-09-19-21/Linux

This is a regression! I would like to see this as nsbeta3, but first it must be
accepted.

Comment 3

[Joe Hewitt (gone)]

I can confirm this as well.  I don't think it's a themes issue, since it shows 
up in both modern and classic the same way.  I think it's related to attributes 
being mis-set when the bookmarks datasource creates the XUL.

Comment 4

[Claudius Gayle]

waterson, rjc, any truth to hewitt's last comment?

Comment 5

[Claudius Gayle]

*** Bug 52762 has been marked as a duplicate of this bug. ***

Comment 6

[Blake Ross]

*** Bug 53342 has been marked as a duplicate of this bug. ***

Comment 7

[Blake Ross]

no, doesn't seem to be.  see bug 53342 for a css patch that, just by a glance, 
looks like it should work (modern and classic probably just have that same 
style rule in bookmarks.css)...

Comment 8

[Joe Hewitt (gone)]

waterson, you can assign this bug to me, I've got all the fixes for it.

The fix in 53342 works like a charm.  That leaves the issue of the iefavorites 
icon not showing up.  This too is an easy fix.  The problem is that the type 
attribute is in the rdf namespace in XUL, but the css is referencing it as a 
xul attribute.  Adding the rdf namespace to bookmark.css and rdf| to all type 
attribute selectors fixes this (in both themes).

I think this one is a no brainer to be ++'ed for RTM at the least, if not 
nsbeta3.

Comment 9

[Joe Hewitt (gone)]

CC'ing Paul Hangas so he can get this one plus'ed and then start the double 
plus begging process.

Comment 10

[Joe Hewitt (gone)]

Now that I have the iefavorites back, I'm noticing that the iefolder icon is 
horrible looking.  I've been told that iefolder.gif and iefavorite.gif (under 
mozilla/themes/classic/communicator/bookmarks) are stolen directly from Mac 
IE5.  Are there any legal issues with this?

Comment 11

[Chris Waterson]

-> hewitt, who has the fix.

Comment 12

[Joe Hewitt (gone)]

This will be fixed as part of our upcoming massive icon checkin.  Marking dup.


*** This bug has been marked as a duplicate of 52271 ***

Comment 13

[Claudius Gayle]

By marking this as a dupe of bug 52271 are we confusing the issue? Isn't having a
different icon independant of it showing up in the proper place?

Comment 14

[Joe Hewitt (gone)]

Claudius, yes it is sort of unrelated, but we have gotten permission to check 
in this fix under the other bug, which has an RTM++.

*** This bug has been marked as a duplicate of 54073 ***

Comment 15

[Joe Hewitt (gone)]

Re-opening and marking depends instead of dup.

Comment 16

[Claudius Gayle]

*** Bug 55269 has been marked as a duplicate of this bug. ***

Comment 17

[Joe Hewitt (gone)]

Fixed.

Comment 18

[sairuh (rarely reading bugmail)]

mass-verifying claudius' Fixed bugs which haven't changed since 2001.12.31.

if you think this particular bug is not fixed, please make sure of the following
before reopening:

a. retest with a *recent* trunk build.
b. query bugzilla to see if there's an existing, open bug (new, reopened,
assigned) that covers your issue.
c. if this does need to be reopened, make sure there are specific steps to
reproduce (unless already provided and up-to-date).

thanks!

[set your search string in mail to "AmbassadorKoshNaranek" to filter out these
messages.]