getURLForIndex method in History interface do not work

VERIFIED FIXED

Status

Core Graveyard
Java APIs to WebShell
P3
normal
VERIFIED FIXED
17 years ago
5 years ago

People

(Reporter: Vladimir Strigun, Assigned: edburns)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

17 years ago
getURLForIndex with correct parameter thrown a raptorWebShellGetURL exception 
and do nothing.
How to reproduce:
Load 4 pages and try to call method getURLForIndex with correct index (0,1,2,3) 
and note that exception raptorWebShellGetURL thrown.
Suggested reason:
Typematch in file /mozilla/java/webclient/src_moz/HistoryImpl.cpp:305
      wsGetURLForIndexEvent * actionEvent = 
	new wsGetURLForIndexEvent(initContext->sHistory,
				  historyIndex);
If change initContext->sHistory to sHistory in this line, then it will works 
correctly.

Reproduced on Mozilla M16 and Webclient sources from 07.31.2000
Confirming due to high quality. edburns@acm.org is the man for this file.

Gerv
Status: UNCONFIRMED → NEW
Ever confirmed: true
(Assignee)

Comment 2

17 years ago
I accept
Status: NEW → ASSIGNED
(Assignee)

Comment 3

17 years ago
Vladimir's fix does work.  I'll attach a patch for review.

Ed
(Assignee)

Comment 4

17 years ago
Created attachment 18972 [details] [diff] [review]
cvs diff -u of fix for this bug, first iteration.
(Assignee)

Comment 5

17 years ago
This fix removes gHistory, and makes it so History.getURLForIndex()
works, thanks to sva@sparc.spb.su (Vladimir Strigun).

M HistoryImpl.cpp
M NativeEventThread.cpp
M WindowControlActionEvents.cpp
M WindowControlImpl.cpp
M WrapperFactoryImpl.cpp
M ns_util.h

HistoryImpl.cpp NativeEventThread.cpp WindowControlActionEvents.cpp 
WindowControlImpl.cpp WrapperFactoryImpl.cpp ns_util.h

Comment 6

17 years ago
r = ashuk

looks good.
(Assignee)

Comment 7

17 years ago
Fix checked in.
(Assignee)

Comment 8

17 years ago
Fix checked in.
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
(Reporter)

Comment 9

16 years ago
Mark this bug as verified.
Verifid with Mozilla/5.0 (Windows; U; WinNT4.0; en-US; rv:0.9.1) Gecko/20010910
Status: RESOLVED → VERIFIED
Component: Java APIs to WebShell → Java APIs to WebShell
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.