474689 - slashdot load time involves 25seconds worth of drawWindow calls

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Comment 1

[(dormant account)]

Progress report.
The slowdown is because large things are painted(ie larger than the screen)..To make matters worse they are painted repeatedly and too frequently(ie the whole page may need to be redrawn a few times a second...while the draws each take a second or a more).

So first thing I did is restrict the the painting to the visible area only which got me down to 10seconds.
Second thing was to put all of the paints into a queue and have things painted in the zoomToPage 2second interval where the queue gets cleared if a zoom occurs. This got rid of a bunch of paints and got me down to 7seconds.
Next thing to do is to knock out draws out of the queue when a new draw makes some of the old ones redundant.

After that I'll add some calculations to be able to flush the rest of the page before panning  and pageload.

Comment 2

[(dormant account)]

in fact, I don't think i ever need to worry about rectangles off screen..should just paint the rest of the page before panning/pageload.

Comment 3

[(dormant account)]

knocking out rectangles seems to be ~20% win

Comment 4

[(dormant account)]

Attachment: limit paints to visible area

This abducts the resize timer and uses it as a paint timer. Resize polling is now less frequent(as it depends on painting outside of the visible area).

Draws are restricted to the visible part of the screen(and are queued up) during page load. Once the page loads, the rest of the page is drawn

Comment 5

[Stuart Parmenter]

it would help clean up this patch to switch all the rectangles to using wsRect and add functionality there as needed.  we'll want to play around with when things get repainted, but definitely looks like we're heading in the right direction

Comment 6

[(dormant account)]

Attachment: cleaned up patch

the code got simplified/optimized thanks to wsRect usage

Comment 7

[(dormant account)]

Attachment: now with more ';'s and prepanning flushing

Comment 8

[(dormant account)]

Attachment: fix

k, this should do panning right by switching off clipped painting mode when the user pans

Comment 9

[Stuart Parmenter]

Comment on attachment 359671 [details] [diff] [review]
fix

lets get this in and keep optimizing

Comment 10

[Brad Lassey [:blassey] (use needinfo?)]

Taras did you land this and can this be closed out?

Comment 11

[(dormant account)]

yes