Closed
Bug 474696
Opened 15 years ago
Closed 15 years ago
Process fallbacks on out-of-domain redirects
Categories
(Core :: Networking: HTTP, defect, P3)
Core
Networking: HTTP
Tracking
()
RESOLVED
FIXED
People
(Reporter: dcamp, Assigned: mayhemer)
Details
(Keywords: fixed1.9.1)
Attachments
(1 file, 1 obsolete file)
5.63 KB,
patch
|
dcamp
:
review+
|
Details | Diff | Splinter Review |
According to the application cache spec: -- Fetch the resource normally. If this results in a redirect to a resource with another origin (indicative of a captive portal), or a 4xx or 5xx status code or equivalent, or if there were network errors (but not if the user canceled the download), then instead get, from the cache, the resource of the fallback entry corresponding to the matched namespace. Abort these steps. -- We currently don't handle the "redirect to a resource with another origin" case.
Flags: blocking1.9.1?
Comment 1•15 years ago
|
||
Dave, what's the result of us not handling this properly here? Trying to figure out whether this needs to block or not...
Reporter | ||
Comment 2•15 years ago
|
||
If someone is connected to a captive portal, and the offline app relies on fallbacks for functionality, the user will get captive portal content instead of the intended fallback.
Assignee | ||
Comment 3•15 years ago
|
||
Patch on top of patch from bug 460335.
Attachment #359271 -
Flags: review?(dcamp)
Assignee | ||
Updated•15 years ago
|
Status: NEW → ASSIGNED
Updated•15 years ago
|
Flags: blocking1.9.1? → blocking1.9.1+
Priority: -- → P3
Assignee | ||
Comment 4•15 years ago
|
||
Fixed typo and perf hit.
Attachment #359271 -
Attachment is obsolete: true
Attachment #359392 -
Flags: review?(dcamp)
Attachment #359271 -
Flags: review?(dcamp)
Comment 5•15 years ago
|
||
Dcamp? Poke for review here.
Reporter | ||
Updated•15 years ago
|
Attachment #359392 -
Flags: review?(dcamp) → review+
Assignee | ||
Comment 6•15 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/cd9c6a4a5e7f
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•15 years ago
|
Attachment #359392 -
Attachment description: v1.1 → v1.1 [Check-in comment 6]
Assignee | ||
Comment 7•15 years ago
|
||
Comment on attachment 359392 [details] [diff] [review] v1.1 [Check-in comment 6][Checkin 1.9.1 comment 7] http://hg.mozilla.org/releases/mozilla-1.9.1/rev/70b3cd0bc64f
Attachment #359392 -
Attachment description: v1.1 [Check-in comment 6] → v1.1 [Check-in comment 6][Checkin 1.9.1 comment 7]
Assignee | ||
Updated•15 years ago
|
Keywords: fixed1.9.1
You need to log in
before you can comment on or make changes to this bug.
Description
•