Closed Bug 474712 Opened 11 years ago Closed 11 years ago

nsROCSSPrimitiveValue should store idents as nsCSSKeyword rather than nsIAtom

Categories

(Core :: DOM: CSS Object Model, defect, P4)

defect

Tracking

()

RESOLVED FIXED
mozilla1.9.2a1

People

(Reporter: dbaron, Assigned: dbaron)

Details

Attachments

(2 files)

We do an awful lot of conversion on CSS keywords to get them into nsIAtoms for nsCSSPrimitiveValue (to string, and then from there to atom).  nsCSSKeywords are already a different set of atoms, and they contain everything we ever put into nsROCSSPrimitiveValue as idents, so it should just use them instead.

I'll attach a series of three patches to fix this.
This is the really boring part.
Attachment #358096 - Flags: superreview?(bzbarsky)
Attachment #358096 - Flags: review?(bzbarsky)
Attachment #358096 - Flags: superreview?(bzbarsky)
Attachment #358096 - Flags: superreview+
Attachment #358096 - Flags: review?(bzbarsky)
Attachment #358096 - Flags: review+
Attachment #358098 - Flags: superreview?(bzbarsky)
Attachment #358098 - Flags: superreview+
Attachment #358098 - Flags: review?(bzbarsky)
Attachment #358098 - Flags: review+
http://hg.mozilla.org/mozilla-central/rev/f8f2b32afabf
http://hg.mozilla.org/mozilla-central/rev/917975b82484
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Priority: -- → P4
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
You need to log in before you can comment on or make changes to this bug.