474779 - Quicksearch cannot find mixed/upper case keywords

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, defect)

Description

[Kent Rogers [:mrbball]]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.12) Gecko/20080327 Firefox/2.0.0.12
Build Identifier: Bugzilla 3.2

According to the quicksearch documentation (page.cgi?id=quicksearch.html),
the following fields are searched by default: Summary, Keywords, Product,
Component, Status Whiteboard.

However, when doing a quicksearch on a keyword that was originally
entered in mixed or upper case, bugs with the specified keyword are
not found.

Here is an example from landfill.  The keyword "KeyMe" is defined on
landfill and there are currently over 100 bugs with that keyword, most
still open:

  https://landfill.bugzilla.org/bugzilla-3.2-branch/buglist.cgi?keywords=KeyMe

Note that the following query also returns the same 100+ bugs:

  https://landfill.bugzilla.org/bugzilla-3.2-branch/buglist.cgi?keywords=keyme

However, if you do a quicksearch of "KeyMe", you only get one bug - the
one that has the text "keyme" in one of the comments:

 https://landfill.bugzilla.org/bugzilla-3.2-branch/buglist.cgi?quicksearch=KeyMe

The problem is that Quicksearch.pm (see lines 353-354) is lower casing
the words specified in the quicksearch and then comparing them to what
comes back from Bugzilla::Keyword->get_all(), and get_all() returns the
keywords exactly as they were entered (i.e. mixed case).

If the quicksearch/keyword mechanism is to work as the other keyword
search mechanisms in Bugzilla (i.e. case insensitively),
Quicksearch.pm needs to lower case the keywords that are returned
from Bugzilla::Keyword->get_all() before comparing against them.  I
will attach a patch for this fix to this bug.

Reproducible: Always

Comment 1

[Kent Rogers [:mrbball]]

Attachment: Fix for 3.2 quicksearch/keyword issue

Patch for Bugzilla version 3.2 that was mentioned in description.

Comment 2

[Frédéric Buclin]

Comment on attachment 358170 [details] [diff] [review]
Fix for 3.2 quicksearch/keyword issue

Let's put this patch in reviewers' radar.

Comment 3

[Frédéric Buclin]

Comment on attachment 358170 [details] [diff] [review]
Fix for 3.2 quicksearch/keyword issue

Works fine. r=LpSolit

Comment 4

[Frédéric Buclin]

tip:

Checking in Bugzilla/Search/Quicksearch.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Search/Quicksearch.pm,v  <--  Quicksearch.pm
new revision: 1.22; previous revision: 1.21
done

3.2.2:

Checking in Bugzilla/Search/Quicksearch.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Search/Quicksearch.pm,v  <--  Quicksearch.pm
new revision: 1.20.2.2; previous revision: 1.20.2.1
done