474902 - Allow the Bug URL (See Also) field to also accept Launchpad bug URLs

Status: RESOLVED FIXED

Description

[Max Kanat-Alexander]

I'd eventually like the inter-Bugzilla functionality stuff to be a general cross-bugtracker functionality. If the other bug-trackers provide APIs, we can update the other bug in some sensible way, and allow them to update us.

Anyhow, the first and easiest thing to do is to add support for launchpad, because it's easy to validate a launchpad URL--it just has "launchpad.net" in the domain.

Some people might argue that this stuff should be in a plugin, but I think it would be nice to have support for all the major bugtrackers built-in to Bugzilla. For now, I think that includes at least Bugzilla, Trac, Launchpad, and Jira.

It should be noted also that Canonical funded all of the work that allowed the "See Also" field to exist at all. We wouldn't have this functionality at all if it weren't for them.

Comment 1

[Max Kanat-Alexander]

Created attachment 358333 [details] [diff] [review]
v1

Okay, this was actually really simple. It didn't involve much code at all.

Comment 2

[David Lawrence [:dkl]]

Comment on attachment 358333 [details] [diff] [review]
v1

>Index: Bugzilla/Bug.pm
>+        # Launchpad bug URLs can look like various things:
>+        #   https://bugs.launchpad.net/ubuntu/+bug/1234
>+        #   https://launchpad.net/bugs/1234
>+        # All variations end with either "/bugs/1234" or "/+bug/1234"

Should this be added to the docs? Maybe there should be a few examples of possible URL's 
for both Bugzilla installations and Launchpad.

Also I tried the case of adding https://launchpad.net/foo_bugs/1234 and it allowed that
to be added. Is this acceptable to Launchpad as you stated it should either be 
the format of "/bugs/1234" or "/+bug/1234"?

Everything else looks good to me and and testing was good. If the above points are not
an issue then r=dkl.

Comment 3

[Max Kanat-Alexander]

(In reply to comment #2)
> Should this be added to the docs? Maybe there should be a few examples of
> possible URL's for both Bugzilla installations and Launchpad.

  Yeah, good point.

> Also I tried the case of adding https://launchpad.net/foo_bugs/1234 and it
> allowed that
> to be added. Is this acceptable to Launchpad as you stated it should either be 
> the format of "/bugs/1234" or "/+bug/1234"?

  Yeah, that's fine. I expect mostly that people will copy-paste URLs, so I'm just doing a basic validation that they're not typing in something totally invalid. Since we normalize them, you can't do anything bad with a funky URL.

Comment 4

[David Lawrence [:dkl]]

Comment on attachment 358333 [details] [diff] [review]
v1

Example urls can go in docs other than the POD docs so r=dkl.

Comment 5

[Max Kanat-Alexander]

Checking in Bugzilla/Bug.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Bug.pm,v  <--  Bug.pm
new revision: 1.276; previous revision: 1.275
done
Checking in Bugzilla/WebService/Bug.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/WebService/Bug.pm,v  <--  Bug.pm
new revision: 1.30; previous revision: 1.29
done