Closed
Bug 474954
Opened 15 years ago
Closed 15 years ago
Remove nsISVGValue_id from nsQueryFrame and remove its use from nsSVGPatternElement
Categories
(Core :: SVG, defect)
Core
SVG
Tracking
()
RESOLVED
FIXED
People
(Reporter: craig.topper, Assigned: craig.topper)
Details
Attachments
(1 file)
|
7.47 KB,
patch
|
roc
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
nsSVGPatternElement::PushUpdate calls do_QueryFrame to get an nsISVGValue, but no frames actually implement nsISVGValue. This means PushUpdate does nothing so it should be removed. This will allow the mutation observer to be removed from nsSVGPatternElement as well since all the observer methods do is call PushUpdate.
Attachment #358356 -
Flags: review?(roc)
Attachment #358356 -
Flags: review?(roc) → review+
Keywords: checkin-needed
Whiteboard: [needs landing]
|
Assignee | |
Comment 1•15 years ago
|
||
Don't you need to sign off superreview too before you can turn check it in?
|
||
Comment 2•15 years ago
|
||
You should have asked him for sr too.
|
|
||
Updated•15 years ago
|
Attachment #358356 -
Flags: superreview?(roc)
Comment on attachment 358356 [details] [diff] [review] Patch With the new rules, you really don't need sr, I think, but that's fine.
Attachment #358356 -
Flags: superreview?(roc) → superreview+
Pushed to trunk: http://hg.mozilla.org/mozilla-central/rev/3d32a38fe008. Thanks!!!
Status: NEW → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [needs landing]
You need to log in
before you can comment on or make changes to this bug.
Description
•