Remove nsISVGValue_id from nsQueryFrame and remove its use from nsSVGPatternElement

RESOLVED FIXED

Status

()

Core
SVG
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: Craig Topper, Assigned: Craig Topper)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

10 years ago
Created attachment 358356 [details] [diff] [review]
Patch

nsSVGPatternElement::PushUpdate calls do_QueryFrame to get an nsISVGValue, but no frames actually implement nsISVGValue. This means PushUpdate does nothing so it should be removed. This will allow the mutation observer to be removed from nsSVGPatternElement as well since all the observer methods do is call PushUpdate.
Attachment #358356 - Flags: review?(roc)
Keywords: checkin-needed
Whiteboard: [needs landing]
(Assignee)

Comment 1

10 years ago
Don't you need to sign off superreview too before you can turn check it in?
You should have asked him for sr too.
Attachment #358356 - Flags: superreview?(roc)
Comment on attachment 358356 [details] [diff] [review]
Patch

With the new rules, you really don't need sr, I think, but that's fine.
Attachment #358356 - Flags: superreview?(roc) → superreview+
Pushed to trunk: http://hg.mozilla.org/mozilla-central/rev/3d32a38fe008. Thanks!!!
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [needs landing]
You need to log in before you can comment on or make changes to this bug.