Closed
Bug 474978
Opened 15 years ago
Closed 15 years ago
Move generation of install.rdf for default theme to be alongside theme files.
Categories
(Thunderbird :: Build Config, defect)
Thunderbird
Build Config
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.0b2
People
(Reporter: standard8, Assigned: standard8)
Details
Attachments
(1 file)
6.11 KB,
patch
|
mkmelin
:
review+
|
Details | Diff | Splinter Review |
The install.rdf that is generated for the classic/default theme currently resides in the easy to remember location mail/app/profile/extensions/{972ce4c6-7e08-4474-a285-3208198ce6fd}/ totally separate from the actual theme files in mail/themes. As it is common to all themes, install.rdf should just reside in mail/themes. We can also tidy up some of the preprocessing, including picking up the python version of the preprocessor. It does mean its best to move the theme selection back to mail/themes (which I only moved recently), though overall I think we will enter one less directory with this patch (and we'll have files in a more logical location. The removal of DEFINES += -DHAVE_SHELL_SERVICE=1 is due to the fact its not required in that directory. Similarly installed-extensions.txt is no longer required.
Attachment #358385 -
Flags: review?(mkmelin+mozilla)
Comment 1•15 years ago
|
||
Comment on attachment 358385 [details] [diff] [review] The fix This didn't build for me. make[5]: *** No rule to make target `/opt/comm-central/src/mail/themes/Makefile.in', needed by `themes/Makefile'. Stop.
Attachment #358385 -
Flags: review?(mkmelin+mozilla) → review-
Assignee | ||
Comment 2•15 years ago
|
||
Comment on attachment 358385 [details] [diff] [review] The fix Did you use patch or git-apply or hg (q)import? If you used patch I expect this wouldn't work as it doesn't know about moving files. The mail/themes/Makefile.in is definitely created in the patch.
Attachment #358385 -
Flags: review- → review?(mkmelin+mozilla)
Comment 3•15 years ago
|
||
Ah yes, I used patch...
Comment 4•15 years ago
|
||
Comment on attachment 358385 [details] [diff] [review] The fix Ok, works fine now! r=mkmelin
Attachment #358385 -
Flags: review?(mkmelin+mozilla) → review+
Assignee | ||
Comment 5•15 years ago
|
||
Patch checked in: http://hg.mozilla.org/comm-central/rev/1824ae4b67d7
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.0b2
You need to log in
before you can comment on or make changes to this bug.
Description
•