474988 - Mismatched adds and removes of install listeners will fail

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Dave Townsend [:mossop]]

If calls to removeInstallListenerAt aren't in the exact opposite order to the calls to addInstallListener then we'll remove the wrong install listener and in some cases end up keeping references to install listeners we shouldn't leading to memory leaks.

Comment 1

[Dave Townsend [:mossop]]

Attachment: patch rev 1

This is kind of lame but I can't see anything particularly easier without changing the API.

Comment 2

[Dave Townsend [:mossop]]

Attachment: now with added tests

Forgot about these

Comment 3

[Dave Townsend [:mossop]]

Comment on attachment 358404 [details] [diff] [review]
now with added tests

Actually I want to add some exception protection around these calls too.

Comment 4

[Dave Townsend [:mossop]]

Attachment: patch rev 2

This adds a helper method for calling the listeners to simplify things a bit. Each call is wrapped with exception handling to prevent a listener from breaking the EM or other listeners.

Comment 5

[Robert Strong (they/them - no direct email)]

Comment on attachment 358829 [details] [diff] [review]
patch rev 2

Nice!

Comment 6

[Dave Townsend [:mossop]]

Pushed: http://hg.mozilla.org/mozilla-central/rev/501b9c8c2f2b