Closed
Bug 474996
Opened 16 years ago
Closed 16 years ago
JS_REQUIRES_STACK violation: TraceRecorder::hasIteratorMethod
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
VERIFIED
FIXED
People
(Reporter: benjamin, Unassigned)
References
Details
(Keywords: verified1.9.1, Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file)
|
973 bytes,
patch
|
jorendorff
:
review+
|
Details | Diff | Splinter Review |
TraceRecorder::hasIteratorMethod needs an annotation.
Attachment #358406 -
Flags: review?(jorendorff)
|
||
Updated•16 years ago
|
Attachment #358406 -
Flags: review?(jorendorff) → review+
|
|
||
Comment 1•16 years ago
|
||
Comment on attachment 358406 [details] [diff] [review]
Annotate it
I've been annotating both the declaration and the definition, because in my simplest mental model of how treehydra might work, that's necessary for the analysis to be correct.
(If this is true, the analysis really should be fixed to detect descrepancies and treat them as errors--just as if you had missed a "const".)
But, yeah, JS_REQUIRES_STACK on this method makes sense.
|
Reporter | |
Comment 2•16 years ago
|
||
http://hg.mozilla.org/tracemonkey/rev/dad9489efde8 pushed to tracemonkey
Whiteboard: fixed-in-tracemonkey
|
||
Comment 3•16 years ago
|
||
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
|
||
Comment 4•16 years ago
|
||
Keywords: fixed1.9.1
|
||
Updated•16 years ago
|
Flags: in-testsuite-
Flags: in-litmus-
|
|
Reporter | |
Comment 5•16 years ago
|
||
bc, all the JS_REQUIRES_STACK bugs have automated (static) tests and should be in-testsuite+
Flags: in-testsuite- → in-testsuite+
|
|
||
Comment 6•16 years ago
|
||
verified 1.9.1, 1.9.2 based on green stack analysis tinderbox on mozilla-central and tracemonkey.
Status: RESOLVED → VERIFIED
Keywords: fixed1.9.1 → verified1.9.1
You need to log in
before you can comment on or make changes to this bug.
Description
•