Closed
Bug 475028
Opened 17 years ago
Closed 17 years ago
Trigger error handler instead of load handler if page fails to load
Categories
(Mozilla Labs :: Prism, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: matthew.gertner, Assigned: matthew.gertner)
Details
Attachments
(1 file, 2 obsolete files)
|
1.65 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
Right now the load() function in webapp.js is called even if the page fails to load. Instead, a different error() handler should be called in this case so that the webapp can take appropriate action.
|
Assignee | |
Comment 1•17 years ago
|
||
I had to move the logic for triggering the webapp.js functions into the web progress listener, which is a fairly significant change. Please review carefully.
Attachment #358421 -
Flags: review?(mark.finkle)
|
|
Assignee | |
Comment 2•17 years ago
|
||
I was getting weird issues accessing the document from the load() handler (called synchronously from onStateChange), which I guess isn't all that surprising. In general, that change was pretty big and could have caused any number of regressions. This approach is more conservative but should accomplish the same thing.
Attachment #358421 -
Attachment is obsolete: true
Attachment #358575 -
Flags: review?(mark.finkle)
Attachment #358421 -
Flags: review?(mark.finkle)
|
|
Assignee | |
Comment 3•17 years ago
|
||
Attachment #358575 -
Attachment is obsolete: true
Attachment #360163 -
Flags: review?(mark.finkle)
Attachment #358575 -
Flags: review?(mark.finkle)
|
||
Updated•17 years ago
|
Attachment #360163 -
Flags: review?(mark.finkle) → review+
|
|
Assignee | |
Comment 4•17 years ago
|
||
Sending runtime/chrome/content/webrunner.js
Transmitting file data .
Committed revision 21937.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•