20.89 KB, patch
Max Kanat-Alexander: review+
|Details | Diff | Splinter Review|
149.36 KB, image/png
319.13 KB, application/x-gzip
348.35 KB, application/x-gzip
It'd be nice to have a very simple index.cgi for logged-out users, probably with just three big buttons: Search (Magnifying glass?) (with a quicksearch box underneath?) File a bug (Either a vector-graphic bug or the standard "new" page icon) Log In (the semi-standard "user bust" icon, perhaps) or perhaps Create Account with a login form underneath it. This could probably be the same page that logged-in users see, for now, since we don't have anything really special for logged-in users on index.cgi right now.
For logged-in users, I suppose the third button could be Preferences? Or perhaps My Bugs.
I was kind of thinking Search would be orange, New bug would be green, and Create Account would be blue, but it's all up to you. :-) And maybe red for My Bugs.
Created attachment 359661 [details] [diff] [review] Patch v1 part one!
Created attachment 359663 [details] [diff] [review] Homepage Images V1 The associated images. Missing dusk but it will basically be the same images but all set to the same dusk color.
Created attachment 359676 [details] [diff] [review] Simpler Homepage V2
Created attachment 359677 [details] Screen Shot V2
Created attachment 359712 [details] Homepage Images V3
Created attachment 359713 [details] [diff] [review] Simpler Homepage V3
Created attachment 359714 [details] Screen Shot V3
Comment on attachment 359712 [details] Homepage Images V3 The magnifier and the person have fuzzy edges, but Buggy doesn't. Also, Buggy is flush to the bottom while the other images are centered. Also, Buggy has some depth (the hidden "other eye") while the other images don't.
Comment on attachment 359713 [details] [diff] [review] Simpler Homepage V3 Also, "Quick Search help" reads like the help is quick, for searching. Perhaps it should just be [Help] or something like we had before? I'll let you decide.
(In reply to comment #14) > Why? I rarely ever load the index page. If this isn't in use on another page > that I do use, why should I ever have to see it? Just makes loading pages > slow... It's used on many pages. It's the base core of YUI, it's required by all other parts of YUI.
Created attachment 360356 [details] [diff] [review] Homepage V4
Created attachment 360357 [details] Homepage Images V4
Created attachment 360358 [details] Homepage V4 Screenshots
Created attachment 361721 [details] [diff] [review] Patch V5 no changes to images or screenshots
Created attachment 361824 [details] [diff] [review] v6 Okay, I looked over it, and it looks great, code-wise. I tested it, and I had to fix some bitrot (so this is the new patch with the bitrot fixed), but it works and looks fine. However, the images need to have transparent backgrounds instead of white backgrounds. I think the images are actually fine even on Dusk, they just need transparent backgrounds. I think PNGs would be better, too, if there's no problem with them.
Holding approval because we need new images.
Created attachment 361859 [details] Hompage Images V5
Created attachment 361860 [details] Homepage V4 Screenshots
Comment on attachment 361824 [details] [diff] [review] v6 The only thing I want to see in this patch, actually, is that the bottom line of links should be further separated from the quicksearch help links--perhaps attached nearer the bottom of the page.
Created attachment 361873 [details] Screen Shots V5
Created attachment 361882 [details] [diff] [review] v7
Created attachment 361885 [details] Screen shots of the final 2 skins
When you check this in, make sure that you add the gifs and mark them as binary for CVS.
I also removed front.png and modified testserver.pl to use padlock.png instead for testing, on checkin. Checking in testserver.pl; /cvsroot/mozilla/webtools/bugzilla/testserver.pl,v <-- testserver.pl new revision: 1.20; previous revision: 1.19 done Checking in skins/standard/index.css; /cvsroot/mozilla/webtools/bugzilla/skins/standard/index.css,v <-- index.css new revision: 1.9; previous revision: 1.8 done RCS file: /cvsroot/mozilla/webtools/bugzilla/skins/standard/index/bug.gif,v done Checking in skins/standard/index/bug.gif; /cvsroot/mozilla/webtools/bugzilla/skins/standard/index/bug.gif,v <-- bug.gif initial revision: 1.1 done Removing skins/standard/index/front.png; /cvsroot/mozilla/webtools/bugzilla/skins/standard/index/front.png,v <-- front.png new revision: delete; previous revision: 1.1 done RCS file: /cvsroot/mozilla/webtools/bugzilla/skins/standard/index/login.gif,v done Checking in skins/standard/index/login.gif; /cvsroot/mozilla/webtools/bugzilla/skins/standard/index/login.gif,v <-- login.gif initial revision: 1.1 done RCS file: /cvsroot/mozilla/webtools/bugzilla/skins/standard/index/seach.gif,v done Checking in skins/standard/index/seach.gif; /cvsroot/mozilla/webtools/bugzilla/skins/standard/index/seach.gif,v <-- seach.gif initial revision: 1.1 done Checking in template/en/default/index.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/index.html.tmpl,v <-- index.html.tmpl new revision: 1.41; previous revision: 1.40 done Checking in template/en/default/attachment/create.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/create.html.tmpl,v <-- create.html.tmpl new revision: 1.38; previous revision: 1.37 done Checking in template/en/default/attachment/created.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/created.html.tmpl,v <-- created.html.tmpl new revision: 1.23; previous revision: 1.22 done Checking in template/en/default/attachment/edit.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/edit.html.tmpl,v <-- edit.html.tmpl new revision: 1.57; previous revision: 1.56 done Checking in template/en/default/attachment/updated.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/updated.html.tmpl,v <-- updated.html.tmpl new revision: 1.21; previous revision: 1.20 done Checking in template/en/default/bug/show.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/show.html.tmpl,v <-- show.html.tmpl new revision: 1.27; previous revision: 1.26 done Checking in template/en/default/bug/create/create.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/create/create.html.tmpl,v <-- create.html.tmpl new revision: 1.93; previous revision: 1.92 done Checking in template/en/default/bug/create/created.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/create/created.html.tmpl,v <-- created.html.tmpl new revision: 1.16; previous revision: 1.15 done Checking in template/en/default/bug/process/header.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/process/header.html.tmpl,v <-- header.html.tmpl new revision: 1.12; previous revision: 1.11 done Checking in template/en/default/global/header.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/global/header.html.tmpl,v <-- header.html.tmpl new revision: 1.61; previous revision: 1.60 done Checking in template/en/default/list/list.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/list/list.html.tmpl,v <-- list.html.tmpl new revision: 1.66; previous revision: 1.65 done
Created attachment 361890 [details] final bundle of images with source files
so, a quick survey shows that we're not happy with your redesign.
(In reply to comment #36) > so, a quick survey shows that we're not happy with your redesign. Is that the Royal We? If it's a few Mozilla developers, who cares? Mozilla isn't going to use that index.cgi anyway. Anyhow, this is something that should be discussed in some other forum, perhaps the Bugzilla developers mailing list, and preferably by the actual individuals who have the feedback, themselves. IRC is also a good place.
it's a we that includes stakeholders and people with experience and common sense. you were pinged twice on irc. the first one timed out.
(In reply to comment #38) > it's a we that includes stakeholders and people with experience and common > sense. Lovely. More meaningless generalities. > you were pinged twice on irc. the first one timed out. Well, have these "stakeholders" and "people with experience" ping me. Or Pyrzak--he's the UI lead.
both of you were pinged. you are failing to PONG. you clearly aren't able to actually use irc.
Added to the release notes for Bugzilla 3.4 in bug 494037.