Closed Bug 475064 Opened 15 years ago Closed 15 years ago

Solaris sh doesn't support "! test"; use "test !" instead

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Platform:
x86
Solaris
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: jimb, Assigned: jimb)

References

Details

(Keywords: fixed1.9.1)

Attachments

(1 file, 1 obsolete file)

Bug 475064: Use 'test !', not '! test' in configure scripts.
2.89 KB, patch
benjamin
: review+
benjamin
: approval1.9.1+
Details | Diff | Splinter Review 
The Solaris 10 /bin/sh doesn't understand 'if ! test ...', but /bin/test does have a '!' operator.
Revised to catch uses in moznbytetype.m4
Assignee: nobody → jim
Attachment #358461 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #358463 - Flags: review?(benjamin)
Attachment #358463 - Flags: review?(benjamin) → review+
Flags: wanted1.9.1?
Requested in 1.9.1: very low risk, necessary for Solaris.
Flags: wanted1.9.1? → wanted1.9.1+
Comment on attachment 358463 [details] [diff] [review]
Bug 475064: Use 'test !', not '! test' in configure scripts.

Land on trunk first, of course.
Attachment #358463 - Flags: approval1.9.1+
Blocks: 475393
Blocks: 475654
Landed in M-C: http://hg.mozilla.org/mozilla-central/rev/eb44ad0afada
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.