Solaris sh doesn't support "! test"; use "test !" instead

RESOLVED FIXED

Status

RESOLVED FIXED
10 years ago
8 months ago

People

(Reporter: jimb, Assigned: jimb)

Tracking

({fixed1.9.1})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

10 years ago
The Solaris 10 /bin/sh doesn't understand 'if ! test ...', but /bin/test does have a '!' operator.
(Assignee)

Comment 1

10 years ago
Created attachment 358461 [details] [diff] [review]
Bug 475064: Use 'test !', not '! test' in configure scripts. r=bsmedberg
(Assignee)

Comment 2

10 years ago
Created attachment 358463 [details] [diff] [review]
Bug 475064: Use 'test !', not '! test' in configure scripts.

Revised to catch uses in moznbytetype.m4
Assignee: nobody → jim
Attachment #358461 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #358463 - Flags: review?(benjamin)

Updated

10 years ago
Attachment #358463 - Flags: review?(benjamin) → review+
(Assignee)

Updated

10 years ago
Flags: wanted1.9.1?
(Assignee)

Comment 3

10 years ago
Requested in 1.9.1: very low risk, necessary for Solaris.

Updated

10 years ago
Flags: wanted1.9.1? → wanted1.9.1+

Comment 4

10 years ago
Comment on attachment 358463 [details] [diff] [review]
Bug 475064: Use 'test !', not '! test' in configure scripts.

Land on trunk first, of course.
Attachment #358463 - Flags: approval1.9.1+

Updated

10 years ago
Blocks: 475393

Updated

10 years ago
Blocks: 475654
(Assignee)

Comment 5

10 years ago
Landed in M-C: http://hg.mozilla.org/mozilla-central/rev/eb44ad0afada
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
(Assignee)

Comment 6

10 years ago
Landed in 1.9.1: http://hg.mozilla.org/releases/mozilla-1.9.1/rev/4837ad70b0ff
Keywords: fixed1.9.1

Updated

8 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.