Closed Bug 475085 Opened 13 years ago Closed 13 years ago

Mochitest leakThreshold should default to 0

Categories

(Testing :: Mochitest, defect)

defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9.2a1

People

(Reporter: Waldo, Assigned: sgautherie)

References

()

Details

(Keywords: fixed1.9.1, Whiteboard: [fixed1.9.1b3])

Attachments

(1 file)

The current default is infinity, which we proceed to override when specific test harnesses are run -- but as of a day or so ago, we always override now.  We should remove the maybe-override code and just always default to 0 to simplify the code.
Severity: minor → trivial
Depends on: 473845, 469444, 435376, 460382, 460548
Target Milestone: --- → mozilla1.9.2a1
Version: unspecified → Trunk
(untested but obvious)

From now on, Firefox (and the other apps) will have to rely on bug 460548.
Assignee: nobody → sgautherie.bz
Status: NEW → ASSIGNED
Attachment #364019 - Flags: review?(jwalden+bmo)
Blocks: 469518
Comment on attachment 364019 [details] [diff] [review]
(Av1) Set global default to 0 from infinity
[Checkin: See comment 4]

Thanks, I wanted to get to this eventually to simplify the code but hadn't found the time yet.
Attachment #364019 - Flags: review?(jwalden+bmo) → review+
Do make sure to test this before landing to be safe, tho -- don't see how anything could go wrong with this, but you never know, I might have missed a typo or something.
Comment on attachment 364019 [details] [diff] [review]
(Av1) Set global default to 0 from infinity
[Checkin: See comment 4]


http://hg.mozilla.org/mozilla-central/rev/07335395bc6f

***

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/add530abc9dc

after fixing context for
{
patching file testing/mochitest/runtests.py.in
Hunk #1 succeeded at 172 with fuzz 1 (offset -17 lines).
Hunk #2 FAILED at 290
1 out of 4 hunks FAILED
}
Attachment #364019 - Attachment description: (Av1) Set global default to 0 from infinity → (Av1) Set global default to 0 from infinity [Checkin: Comment 4]
Attachment #364019 - Attachment description: (Av1) Set global default to 0 from infinity [Checkin: Comment 4] → (Av1) Set global default to 0 from infinity [Checkin: See comment 4]
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Flags: in-testsuite-
Keywords: fixed1.9.1
Resolution: --- → FIXED
Whiteboard: [fixed1.9.1b3]
No longer blocks: 469518
You need to log in before you can comment on or make changes to this bug.