475138 - Undo-close-tab opens in wrong order and messes up Cmd-# tab jump

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Ed Lee :Mardak]

1) Open a new window (cmd-n) then open 2 new tabs (cmd-t, cmd-t)
2) Switch to tab #2 (cmd-2) [one left of the last opened tab]
3) Close tab #2 (cmd-w), and close new tab #2 (cmd-w)
4) Undo close tab twice (cmd-shift-t, cmd-shift-t)

expected: 2 blank tabs to the right of the initial tab like..
[original tab cmd-1][blank tab1 cmd-2][blank tab2 cmd-3]

actual: original tab #1 (cmd-1) is in position 2, cmd-2 activates the first tab (tab #2)
[blank tab1 cmd-2][original tab cmd-1][blank tab2 cmd-3]

Beltzner: Potentially would want to backout unless we find a fix soon? But maybe not if undo close tab is the only way to trigger it.. ?

Comment 1

[:Gavin Sharp [email: [e-mail]]]

I've seen this too, but I'm pretty sure it was before bug 457651 landed. What makes you think it's to blame?

Comment 2

[Ed Lee :Mardak]

Oh. I just tried it on a new profile. Undo-close-tab doesn't remember blank tabs (I had auto dial installed).

Just open 2 tabs from the original tab and the same thing happens.

cmd-n, cmd-click 2 links, cmd-2, cmd-w, cmd-w, cmd-shift-t, cmd-shift-t

(In reply to comment #1)
> I've seen this too, but I'm pretty sure it was before bug 457651 landed. What
> makes you think it's to blame?
I didn't see it before? ;) I'll check the regression range, but the <children/> stuff seems suspicious.

Comment 3

[Ed Lee :Mardak]

Hey! False alarm. :)

01-22 is good
01-23 is broken

Comment 4

[Ed Lee :Mardak]

Oh nevermind. My clock said 01-24, but I didn't realize it was the next day.

But good news is that bug 474964 fixed this problem. (hg export 24146 | patch -R -p1 and the problem showed up again.)

So original regression was correct but already fixed. :)

Comment 5

[Ed Lee :Mardak]

(Didn't realize bug 474964 was still open, but to be specific, the comment fix has fixed this problem.)

http://hg.mozilla.org/mozilla-central/rev/096ab3b6abe0
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/ca801f82facf

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified on trunk and 1.9.1 with:

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20090125
Shiretoko/3.1b3pre (.NET CLR 3.5.30729) ID:20090125052901

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b3pre)
Gecko/20090126 Shiretoko/3.1b3pre Ubiquity/0.1.5 ID:20090126020313

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090125
Minefield/3.2a1pre ID:20090125034316

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre)
Gecko/20090126 Minefield/3.2a1pre ID:20090126020316

We should update the existing litmus tests to also cover this issue.