Closed Bug 475163 Opened 15 years ago Closed 15 years ago

Trunk bloat tests failing due to changed automation.py structure

Categories

(MailNews Core :: Build Config, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(1 file)

Bug 464191 checked in a change to how automation.py is working. Unfortunately this breaks how our bloat tests call that file.

I think we may be able to figure out some way of determining if it call it one way or another, though I've not really looked yet. I'm also going to try and find out if bug 464191 will be landing on the 1.9.1 branch or not.
Attached patch The fixSplinter Review
This fixes the problem and works for both trunk and 1.9.1 - basically if one fails, fall back to the other. Note that the MOZILLA_1_9_1_BRANCH in the comment is intentional to aid searching for things to remove when we actually branch.

I'm going to push this to the tree now with pending review and hopefully get some green back onto trunk.
Attachment #358623 - Flags: review?(gozer)
Whiteboard: [fixed but pending review gozer]
Comment on attachment 358623 [details] [diff] [review]
The fix

Looks like it worked, so granting retroactive review ;-)
Attachment #358623 - Flags: review?(gozer) → review+
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Whiteboard: [fixed but pending review gozer]
You need to log in before you can comment on or make changes to this bug.