Closed Bug 47519 Opened 24 years ago Closed 22 years ago

show tooltip for href (links), src (images) and name (named anchors)

Categories

(SeaMonkey :: Composer, defect, P3)

defect

Tracking

(Not tracked)

VERIFIED FIXED
mozilla1.4alpha

People

(Reporter: Brade, Assigned: glazou)

References

Details

(Keywords: helpwanted, polish, topembed+)

Attachments

(1 file, 4 obsolete files)

The following changes should be made to the statusbar area (based on a review of
the current UI):
 * make the area shorter (to match resize icon on Mac)
 * look at navigator.xul for consistency
 * clear the status text after the user has made a modification (or some other
similar time)
Keywords: nsbeta3, polish
Target Milestone: --- → M18
setting to nsbeta3+
Whiteboard: [nsbeta3+]
Status: NEW → ASSIGNED
Whiteboard: [nsbeta3+] → [nsbeta3+][p:3]
beppe said she'd like me to take a look at this bug, so I'll reassign to myself 
and fix it.
Assignee: sfraser → rcassin
Status: ASSIGNED → NEW
Reassigning to sfraser@netscape.com -- I don't have a mac so I can't work on 
this one :\
Assignee: rcassin → sfraser
Simon: can you also make it display link URL like the browser does?
This is related to bug 26250.
this is just going to have to wait, with the timeframe we have and the number of 
bugs on the list, we just can't do them all
Keywords: helpwanted
Whiteboard: [nsbeta3+][p:3] → [nsbeta3-]
Target Milestone: M18 → Future
Blocks: 65785
Blocks: 26250
Depends on: 60010
also:

1) launch netscape
2) launch composer

look at the bottom pane of window. It says: "Done loading page"

we don't need this string for the composer especially for a blank page.
-> editor owners
Assignee: sfraser → syd
Component: Editor: Core → Editor: Composer
Status: NEW → ASSIGNED
Whiteboard: [nsbeta3-]
Keywords: nsbeta1
--> kathy, 1.2alpha, nsbeta1+
Assignee: syd → brade
Status: ASSIGNED → NEW
Keywords: nsbeta1nsbeta1+
Target Milestone: Future → mozilla1.2alpha
Can we also include "show URL in the status bar when mouse-over a link" as part 
of this task? I.e., let's use the status bar for something useful!
Summary: statusbar cleanup → statusbar cleanup -- show link href in status area.
We should look at this from a generic notification standpoint. Other Gecko mail
using apps should be able to expose the same type of thing in their own app/UI.
Keywords: topembed
Target Milestone: mozilla1.2alpha → mozilla1.4alpha
Keywords: topembedtopembed+
*** Bug 65785 has been marked as a duplicate of this bug. ***
-->glazman per his request
Assignee: brade → glazman
accepting bug ; after bug 173319's fix, the status bar is not available any more
so I propose a tooltip. Fix pending.
Status: NEW → ASSIGNED
Summary: statusbar cleanup -- show link href in status area. → show tooltip for href (links), src (images) and name (named anchors)
Attached patch patch v1.1 (obsolete) — Splinter Review
Attachment #103053 - Attachment is obsolete: true
Comment on attachment 103055 [details] [diff] [review]
patch v1.1

r=brade
Attachment #103055 - Flags: review+
Comment on attachment 103056 [details] [diff] [review]
patch v1.2, carries forward r=brade

==== I thought that in JS, the 2 expressions below were equivalent? That is an
empty string evaluated to a |false| just like a null did?

+    if (popuptext && popuptext != "") {


sr=kin@netscape.com
Attachment #103056 - Flags: superreview+
I think this could wait for 1.3alpha.
kin's right, it's redundant to test

+    if (popuptext && popuptext != "") {

in JS.

This patch is fine 1.3alpha material -- the trunk should open for 1.3alpha on
Friday, or possibly Monday.  Anyone deriving products from the trunk before then
should patch locally.

/be
Attachment 103056 [details] [diff] only checks the innermost element; in the case of (say) the
"The Mozilla Organization" link on the Mozilla home page the text is wrapped in
a <b> so that you need to walk up the tree to find the link, or alternatively
to find an anchor. You probably don't have to walk up in the case of images but
I couldn't think of an easy way to special case them.
Comment on attachment 104634 [details] [diff] [review]
I don't think glazou's patch works in all cases


>+      tooltipText = node.src;
>+    else if (node instanceof Components.interfaces.nsIDOMHTMLAnchorElement)
>+      tooltipText = node.href || node.name;

If you do that instead of .getAttribute("src") and .getAttribute("href"), the
tooltip
will display the local path of an anchor. For instance, if you edit c:\foo.htm
and want
to see the tooltip of <a href="#bar">, it will show file:///c:/foo.htm#bar and
I don't
think it is desireable.

otherwise r=glazman and thanks a lot for detecting this case
Attachment #104634 - Flags: review+
Attachment #103056 - Attachment is obsolete: true
Attachment #104634 - Attachment is obsolete: true
Comment on attachment 105315 [details] [diff] [review]
Fixed glazou's issue

r=glazman
Attachment #105315 - Flags: review+
checked in (trunk)
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
when i mouseover a link <a href..>, an image <img src...> or an anchor <a
name..> in composer, a tooltip now appears. vrfy'd fixed with 2003.02.19 on
win2k and mac 10.2.4.
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: