475281 - crash when dismissing customize toolbar sheet while drag is in progress

Status: RESOLVED WORKSFORME

(Camino Graveyard :: Toolbars & Menus, defect)

Description

[Samuel Sidler (old account; do not CC)]

Attachment: Crash log

STR:
  1. View -> Customize Toolbar...
  2. Drag the Location/Search bar widget from the sheet to the toolbar
  3. Do not release the drag
  4. Press esc (the sheet will disappear)
  5. Place the location bar and search bar on the toolbar

ER:
  At step 4, 'esc' should have canceled the drag, not removed the sheet.

AR:
  Crash after step 5.

This was using Camino 2.0b1 on Mac OS X 10.5.6.

Comment 1

[Chris Lawson (gone)]

Does that same crash log always happen? It looks semi-bogus.

I can't repro step 4 in 1.6.6 or the trunk nightly from Thursday with a fresh profile, by the way -- the sheet stays there and the drag cancels, as it should.

Comment 2

[Chris Lawson (gone)]

Both the attempts to repro in comment 1 were PPC. I won't be able to try this on Intel until at least Wednesday.

Comment 3

[philippe (part-time)]

I can't repro comment 0 here on Intel/10.5.6 with an up-to-date trunk and my normal profile. And not with a default profile with the 2009012100 build.

I both cases @ step 4 the drag is cancelled and the sheet stays open.

(before step 1 I removed the location+search bar from the toolbar)

Comment 4

[davedit]

Attachment: 2.0b2 crash

I tried the described steps using 2.0b2 and I was unable to reproduce the crash. Pushing escape cancels the drag. However, I have had a few crashes in the past when customizing my toolbar. Attached is a crash log from 2.0b2 that I thought looked similar.

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Stuart, is there anything we can do with this?

Comment 6

[Stuart Morgan]

If anyone can repro it they could try with NSZombieEnabled and we can see what the object is. I can't repro it either though.

Comment 7

[Samuel Sidler (old account; do not CC)]

I can't reproduce anymore. Feel free to WFM it.

Comment 8

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

murph saw a crash with similar STR as this, bp-0cb39afe-c2bb-4ab3-a216-80e042090512

"In the customize toolbar sheet, dragged a script item button then released back in the original spot on sheet, crashed when sheet closed. (It's Murph here :))"

The crashing thread looks the same, too (insofar as I can tell with a crash the day before I uploaded OS symbols).

Comment 9

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

bp-56b1f965-6d84-42fd-886f-a21062090607 is another similar-sounding crash: "I wanted to add a new item to the menubar (the add bookmark). Then the cursor with the plus-sign appeard and did not go away. Then Camino crashed."

murph's crash report in comment 8 actually looks like the objc_msgSend crashes that we've seen in b3 and haven't yet been able to classify as an existing bug.

Comment 10

[Stuart Morgan]

Note that the comment 9 crash has 1Password, and we know that there is a 1Password+toolbar customization crash, so it's probably different.