Closed Bug 475323 Opened 15 years ago Closed 15 years ago

Fix incorrectly defined accesskey in Customisable toolbars context menu

Categories

(SeaMonkey :: UI Design, defect)

Product:
SeaMonkey
Component:
UI Design
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
seamonkey2.0a3

People

(Reporter: wladow, Assigned: wladow)

References

Details

(Keywords: polish)

Attachments

(1 file, 1 obsolete file)

fix accesskeys, v2 [Checkin: Comment 4]
1.93 KB, patch
neil
: review+
Details | Diff | Splinter Review
Attached patch fix an accesskey (obsolete) — — Splinter Review 
This accesskey definition needs to be fixed:
       label="&customizeToolbar.useDefault.label;"
       accesskey="&customizeToolbar.useDefault.label;"/>
Attachment #358818 - Flags: review?(neil)
Comment on attachment 358818 [details] [diff] [review]
fix an accesskey

Ah, so that explains why I failed to notice the abysmal choice of access key :-( Could you improve it please?
Attachment #358818 - Flags: review?(neil) → review-
Right, and we can use better keys instead of 'I' and 't' as well.
Assignee: nobody → wladow
Status: NEW → ASSIGNED
Attachment #358819 - Flags: review?(neil)
Comment on attachment 358819 [details] [diff] [review]
fix accesskeys, v2
[Checkin: Comment 4]

I'm not 100% convinced with "o" but (especially in a sans serif font) it's still better than "I" :-)
Attachment #358819 - Flags: review?(neil) → review+
Keywords: checkin-needed
Attachment #358818 - Attachment is obsolete: true
Attachment #358819 - Attachment description: fix accesskeys, v2 → fix accesskeys, v2 [Checkin: Comment 4]
Blocks: 428216
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.