475348 - Add Search/Filter Functionality to All.html Page

Status: VERIFIED FIXED

(www.mozilla.org :: General, defect)

Description

[Steven Garrity [:sgarrity]]

Patch is attached.

Comment 1

[Reed Loden [:reed]]

Patch isn't attached.

Comment 2

[Steven Garrity [:sgarrity]]

Attachment: patch to product-details lib to add search functionality

Comment 3

[Wil Clouser [:clouserw]]

I made some minor tweaks but it's ready to commit except you're using escapeForJavaScript() which is never defined

Comment 4

[Steven Garrity [:sgarrity]]

(In reply to comment #3)
> I made some minor tweaks but it's ready to commit except you're using
> escapeForJavaScript() which is never defined

escapeForJavaScript() was added to include/functions.inc.php in r15399. Is it not safe to assume that functions.inc.php is accessible from this page? This is working on our stage copy.

Comment 5

[Wil Clouser [:clouserw]]

Ok, since this function is just for moz.com I committed it (r21779).  Calling functions that aren't in the library is a bad practice but I'm ignoring it for now while we are in this testing phase.  Thanks

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED: https://www-trunk.stage.mozilla.com/en-US/firefox/all-3.html?lang-search=sloven%C4%8Dina&x=0&y=0; tested with JavaScript disabled, too, over in bug 475760.