Closed Bug 475393 Opened 11 years ago Closed 11 years ago

Standalone Spidermonkey should build on Solaris with GCC

Categories

(Core :: JavaScript Engine, defect)

All
Solaris
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: wes, Assigned: wes)

References

Details

Attachments

(1 file, 1 obsolete file)

configure.in incorrectly adds SunStudio-specific libraries to its test programs.  Systems without these libraries installed cannot successfully complete a run of ./configure.

Reproduction is simple:
# autoconf-2.13
# ./configure
(many lines of output)
checking for unwind.h... no
checking for gcc -pipe support... no
checking whether compiler supports -Wno-long-long... yes
checking whether C compiler supports -fprofile-generate... yes
checking whether C++ compiler has -pedantic long long bug... no
checking for correct temporary object destruction order... no
configure: error: Your compiler does not follow the C++ specification for temporary object destruction order.

Note: top-level configure.in also suffers from this defect, however circumstances preclude me from being able to patch and test reasonably, so I am not submitting a patch for the top-level.

I have tested this patch with Solaris-10-shipped GCC 3.4.3, GNU linker, tracemonkey-73bfcdaa1a51 and the patch in bug 475064.
Attachment #358892 - Flags: review?(jim)
Attachment #358892 - Flags: review?(jim) → review+
That patch looks fine to me for js/src/configure.in.  Let's leave this bug open until we can get confirmation that it's okay for the top-level configure.in, too.
Alfred Peng writes:

> Hi Jim,
>
> This looks good to me and thanks for the patch :-)
>
> It's nice to build SpiderMonkey with GCC on Solaris/OpenSolaris even though the > recommended compiler is Sun Studio.
> 
> Best Regards,
> -Alfred

So, Wes, if you want to adapt this patch to cover both js/src/configure.in and the top configure.in, we'll be good to go.
This should correct the same defect documented above for js/src/configure.in for the top-level configure.in as well.
Attachment #358892 - Attachment is obsolete: true
Attachment #359201 - Flags: review?(jim)
Attachment #359201 - Attachment is patch: true
Attachment #359201 - Attachment mime type: application/octet-stream → text/plain
Attachment #359201 - Flags: review?(jim) → review+
Note feedback from Solaris maintainer Alfred Peng.
Flags: wanted1.9.1?
Assignee: general → wes
Status: NEW → ASSIGNED
Whiteboard: checkin-needed
Pushed
http://hg.mozilla.org/mozilla-central/rev/952fad29c3c6
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: checkin-needed
Flags: in-testsuite-
Flags: wanted1.9.1?
You need to log in before you can comment on or make changes to this bug.