475393 - Standalone Spidermonkey should build on Solaris with GCC

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Wesley W. Garland]

Attachment: Patch to move LIBS assignment to GNU_CC-guarded section

configure.in incorrectly adds SunStudio-specific libraries to its test programs.  Systems without these libraries installed cannot successfully complete a run of ./configure.

Reproduction is simple:
# autoconf-2.13
# ./configure
(many lines of output)
checking for unwind.h... no
checking for gcc -pipe support... no
checking whether compiler supports -Wno-long-long... yes
checking whether C compiler supports -fprofile-generate... yes
checking whether C++ compiler has -pedantic long long bug... no
checking for correct temporary object destruction order... no
configure: error: Your compiler does not follow the C++ specification for temporary object destruction order.

Note: top-level configure.in also suffers from this defect, however circumstances preclude me from being able to patch and test reasonably, so I am not submitting a patch for the top-level.

I have tested this patch with Solaris-10-shipped GCC 3.4.3, GNU linker, tracemonkey-73bfcdaa1a51 and the patch in bug 475064.

Comment 1

[Jim Blandy :jimb]

That patch looks fine to me for js/src/configure.in.  Let's leave this bug open until we can get confirmation that it's okay for the top-level configure.in, too.

Comment 2

[Jim Blandy :jimb]

Alfred Peng writes:

> Hi Jim,
>
> This looks good to me and thanks for the patch :-)
>
> It's nice to build SpiderMonkey with GCC on Solaris/OpenSolaris even though the > recommended compiler is Sun Studio.
> 
> Best Regards,
> -Alfred

So, Wes, if you want to adapt this patch to cover both js/src/configure.in and the top configure.in, we'll be good to go.

Comment 3

[Wesley W. Garland]

Attachment: Patch to move LIBS assignment to GNU_CC-guarded section for top-level AND spidermonkey builds

This should correct the same defect documented above for js/src/configure.in for the top-level configure.in as well.

Comment 4

[Jim Blandy :jimb]

Note feedback from Solaris maintainer Alfred Peng.

Comment 5

[Ginn Chen]

Pushed
http://hg.mozilla.org/mozilla-central/rev/952fad29c3c6