Closed
Bug 47552
Opened 24 years ago
Closed 24 years ago
[FIX]Change use of nsIFileWidget to nsIFilePicker in nsFileControlFrame.cpp
Categories
(Core :: Layout: Form Controls, defect, P1)
Tracking
()
VERIFIED
FIXED
M18
People
(Reporter: pavlov, Assigned: rods)
References
Details
(Keywords: memory-footprint, Whiteboard: [nsbeta3+]Fix in hand; requested eng'ring feedback-ckritzer;)
Attachments
(2 files)
|
7.47 KB,
patch
|
Details | Diff | Splinter Review | |
|
283 bytes,
patch
|
Details | Diff | Splinter Review |
mozilla/layout/html/forms/src/nsFileControlFrame.cpp uses nsIFileWidget which
will be removed towards the end of beta3. Please change this code to use
nsIFilePicker instead.
|
Reporter | |
Updated•24 years ago
|
Blocks: 47551
Keywords: correctness,
nsbeta3
|
Assignee | |
Updated•24 years ago
|
Status: NEW → ASSIGNED
Target Milestone: --- → M18
|
||
Comment 1•24 years ago
|
||
Adding [NEEDINFO] to status whiteboard. Rod, is this a simple change?
Whiteboard: [NEEDINFO]
|
|
Assignee | |
Comment 2•24 years ago
|
||
Adding dependency.
As it turns out, the patch 40976 fixes this bug also.
Depends on: 40976
|
|
||
Comment 4•24 years ago
|
||
Marking nsbeta3+. Added footprint keyword
Keywords: footprint
Whiteboard: [NEEDINFO] → [nsbeta3+]
|
||
Comment 5•24 years ago
|
||
|
|
Assignee | |
Updated•24 years ago
|
Summary: Change use of nsIFileWidget to nsIFilePicker in nsFileControlFrame.cpp → [FIX]Change use of nsIFileWidget to nsIFilePicker in nsFileControlFrame.cpp
|
|
Assignee | |
Updated•24 years ago
|
Whiteboard: [nsbeta3+] → [nsbeta3+]Fix in hand
|
|
Assignee | |
Comment 7•24 years ago
|
||
fixed
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
|
||
Comment 8•24 years ago
|
||
Pav, Rod, how would you suggest this be tested?
Whiteboard: [nsbeta3+]Fix in hand → [nsbeta3+]Fix in hand; requested eng'ring feedback-ckritzer;
|
|
Assignee | |
Comment 9•24 years ago
|
||
verify that it works like it should, since I claim to have changed the code :)
|
|
Reporter | |
Comment 10•24 years ago
|
||
easiest way is to see if you get the xp file picker on linux when you try to
submit a patch on bugzilla (I believe)
|
|
||
Comment 11•24 years ago
|
||
|
|
||
Updated•24 years ago
|
Status: RESOLVED → VERIFIED
|
|
||
Comment 12•24 years ago
|
||
Okay, I uploaded on Linux and Windows to bug#46396 by mistake (that'll learn me
to have multiple bug report windows open), but it *does* work.
Marking VERIFIED FIXED on:
- LinuxRH62 2000-09-13-08-M18 Commercial
- Win98 2000-09-13-08-M18 Mozilla
- MacOS86 2000-09-13-04-M18 Commercial
You need to log in
before you can comment on or make changes to this bug.
Description
•