475523 - "Accept bug" command referenced in whineatnews but doesn't exist

Status: RESOLVED FIXED

(Bugzilla :: Email Notifications, defect)

Description

[Eric Olson]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.5) Gecko/2008120122 Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1)
Build Identifier: 3.2

Whine emails contain the text "You decide the bug belongs to you, but you can't solve it this moment. Just use the "Accept bug" command." I believe the "Accept bug" command was removed for 3.2, at least according to bug 447890.

This is potentially confusing to users. I, at least, was looking all over the bug page for several minutes looking for a button that wasn't supposed to be there.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Kent Rogers [:mrbball]]

Attachment: patch for v3.4 branch, v1

Simple patch to bring whineatnews emails up to date.

Comment 2

[Teemu Mannermaa (:wicked)]

Comment on attachment 408435 [details] [diff] [review]
patch for v3.4 branch, v1

>Index: template/en/default/email/whine.txt.tmpl
>===================================================================
>>     "Accept the [% terms.bug %]" by resetting the status to [% get_status("ASSIGNED") %].

I'd use word "setting" rather than "resetting" there. This can be fixed on check in (if approver agrees).

This patch only applies to the 3.4 branch since on trunk get_status() has been changed to display_value().

BTW, for future reference, unified diffs with some context lines would be nicer patch format.

Comment 3

[Teemu Mannermaa (:wicked)]

Attachment: Patch for trunk, V1

This is a simple port to trunk so that we can get this bug finally fixed. (Apologies for not getting to this review in a timely manner!)

I did add one additional "missing space" fix (it has been always there and nobody noticed or didn't bother) that should probably be also fixed on the 3.4 branch version before checkin..

Comment 4

[Frédéric Buclin]

Comment on attachment 418486 [details] [diff] [review]
Patch for trunk, V1

>+[%= display_value("bug_status", "REOPENED") %] state, and have not been

Should be [%+ isn't it?


>+    "Accept the [% terms.bug %]" by setting the status to [% display_value("bug_status", "ASSIGNED") %].

Quotes no longer make sense. It's not the name of an action anymore.

Comment 5

[Frédéric Buclin]

Comment on attachment 408435 [details] [diff] [review]
patch for v3.4 branch, v1

>>     "Accept the [% terms.bug %]" by resetting the status to [% get_status("ASSIGNED") %].

wicked is right about s/resetting/setting/. And here too, quotes do not make sense anymore.

Comment 6

[Teemu Mannermaa (:wicked)]

(In reply to comment #4)
> >+[%= display_value("bug_status", "REOPENED") %] state, and have not been
> Should be [%+ isn't it?

No, [%= is right as I want everything eaten and add only one space (currently there's no space between "or" and "REOPENED". Please, read http://www.template-toolkit.org/docs/manual/Config.html#section_PRE_CHOMP_POST_CHOMP for details on all four chomp flags.

> >+    "Accept the [% terms.bug %]" by setting the status to [%  
> Quotes no longer make sense. It's not the name of an action anymore.

Ah, you're actually right! However, the quotes on the other change (in option 2) make the option to choose visually pop out, which is nice.

Comment 7

[Max Kanat-Alexander]

The 3.4 patch should be made into a diff -u though.

Comment 8

[Teemu Mannermaa (:wicked)]

Attachment: Patch for v3.4 branch, V1

This is the Kent's patch with nits fixed and in unified diff format.

Comment 9

[Teemu Mannermaa (:wicked)]

Thanks for the patch, Kent! I checked them in fixing the quotes on the trunk patch.

3.4 branch:
Checking in template/en/default/email/whine.txt.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/email/whine.txt.tmpl,v  <--  whine.txt.tmpl
new revision: 1.7.2.1; previous revision: 1.7
done

trunk:
Checking in template/en/default/email/whine.txt.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/email/whine.txt.tmpl,v  <--  whine.txt.tmpl
new revision: 1.9; previous revision: 1.8
done

Comment 10

[Kent Rogers [:mrbball]]

Sorry I didn't respond earlier - I was on vacation.  Thanks for wrapping
this up.

Comment 11

[Teemu Mannermaa (:wicked)]

Please, you did all the hard work so let's leave this assigned to you. I only fixed simple nits and formatting since otherwise I couldn't have granted review for these patches. :)