Closed Bug 475564 Opened 16 years ago Closed 15 years ago

Clear Recent History dialog should not be minimized

Categories

(Firefox :: General, defect)

Product:
Firefox
Component:
General
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 3.6a1

People

(Reporter: deanis74, Assigned: ehsan.akhgari)

Details

(Keywords: polish, verified1.9.1)

Attachments

(1 file)

Patch (v1)
849 bytes, patch
Gavin
: review+
beltzner
: approval1.9.1+
Details | Diff | Splinter Review 
You should not be able to minimize the dialog.  It's modal, and minimizing the dialog causes all of Firefox to minimize, but not to the taskbar just to the bottom corner of the desktop.
Component: Private Browsing → General
QA Contact: private.browsing → general
Summary: Clear Private Browsing dialog can be minimized → Clear Private Data dialog can be minimized
Keywords: polish
For clarification, the dialog I'm talking about is "Clear Recent History".  It's accessed from both...

1. Tools > Options > Privacy > Private Data > Clear Now
In this case, minimizing the dialog does not minimize anything else.

2. From the "clearing your recent history" link in about:privatebrowsing.  This is where I originally noticed the problem.
Attached patch Patch (v1) — — Splinter Review 
A very trivial patch.
Assignee: nobody → ehsan.akhgari
Status: NEW → ASSIGNED
Attachment #359088 - Flags: review?(gavin.sharp)
(In reply to comment #1)
> For clarification, the dialog I'm talking about is "Clear Recent History". 

Yeah, sorry I'm still used to the old name...
Summary: Clear Private Data dialog can be minimized → Clear Recent History dialog should not be minimized
Attachment #359088 - Flags: review?(gavin.sharp) → review+
http://hg.mozilla.org/mozilla-central/rev/f3ca4ce9d865
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Flags: in-litmus?
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.2a1
Attachment #359088 - Flags: approval1.9.1?
I don't see this in the nightly that I downloaded this morning.  Should I?

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20090203 Shiretoko/3.1b3pre (.NET CLR 3.5.21022)
Dean: This bug is fixed on the trunk, which means Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090203 Minefield/3.2a1pre. It has not yet been checked into the 1.9.1 branch which means you should still see it on the build you posted in Comment 5. When the keyword fixed1.9.1 is added to the bug it will be fixed on that branch.
Status: RESOLVED → VERIFIED
Huh.  And here I thought I was running trunk builds.  Guess I'll have to update!
Comment on attachment 359088 [details] [diff] [review]
Patch (v1)

a191=beltzner
Attachment #359088 - Flags: approval1.9.1? → approval1.9.1+
Verified fixed on the 1.9.1 branch using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b4pre) Gecko/20090327 Shiretoko/3.5b4pre.
Keywords: fixed1.9.1 → verified1.9.1
https://litmus.mozilla.org/show_test.cgi?id=7725 added to Litmus.
Flags: in-litmus? → in-litmus+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: