47561 - Incorrect group bit used for new group

Status: VERIFIED FIXED

(Bugzilla :: Bugzilla-General, defect, P2)

Description

[Troy Engel]

editgroups.cgi:261
value is 65535 - this is one less than it should be, 65536; reasons should be
obvious (how did this never get found? huh).  As soon as you add a new group
with this value, everything in edituser.cgi just breaks hard (as I'm sure it
does elsewhere).  Stopped me from using groups completely till I tracked it
down, hence the Blocker severity.

Comment 1

[Troy Engel]

changed to critical, not blocker - my mistake.

Comment 2

[Dave Miller [:justdave]]

This is my code...  I'll take this.

Comment 3

[Dave Miller [:justdave]]

stupid lameass typo.  Attaching a patch...

Comment 4

[Dave Miller [:justdave]]

Attachment: patch to fix this

Comment 5

[Dave Miller [:justdave]]

Due to the way this kinda breaks things, and it's a straightforward fix, I went 
ahead and checked it into the tree.

Comment 6

[Dave Miller [:justdave]]

And it wasn't a complete fix...  from news:netscape.public.mozilla.webtools :

On 08/07/00 9:49 AM +0200, Wojtek Pilorz wrote:

>I undestand that @bitvals is supposed to contain consequtive powers of 2;
>So I converted @bitvals to a text file using vi, and run the following:
>
>$ echo 'for (i=0;i<63;++i) { 2^i; }' | bc | diff -u bitvals.txt -
>--- bitvals.txt Mon Aug  7 08:52:25 2000
>+++ -   Mon Aug  7 09:18:05 2000
>@@ -59,5 +59,5 @@
> 288230376151711744
> 576460752303423488
> 1152921504606846976
>-2305843009213693958
>-4611686018427387916
>+2305843009213693952
>+4611686018427387904
>
>So last two values of @bitvals are not powers of 2;
>Seems like a bug.>

Comment 7

[JMF]

*** Bug 52251 has been marked as a duplicate of this bug. ***

Comment 8

[Dave Miller [:justdave]]

oops, this one slipped off my back burner...  I wish "reopened" would send
whine mail. :)  Moving back to NEW so I don't lose it again.  Putting in queue
for 2.12 - this potentially causes data corruption, it needs to be fixed.

Comment 9

[Dave Miller [:justdave]]

Attachment: Patch to fix the rest of this.

Comment 10

[Chris Yeh]

committed to trunk

Comment 11

[Dave Miller [:justdave]]

oops, thought I'd already committed that. :)  Must have been sleeping last night.  Thanks Chris.

Comment 12

[Dave Miller [:justdave]]

*** Bug 52471 has been marked as a duplicate of this bug. ***

Comment 13

[Dave Miller [:justdave]]

*** Bug 70638 has been marked as a duplicate of this bug. ***

Comment 14

[Tara Hernandez]

Sorry for the spam, but I needed to be able to query for all of these correctly.

Comment 15

[Gervase Markham [:gerv]]

VERIFIED.

Gerv

Comment 16

[Dave Miller [:justdave]]

Moving closed bugs to Bugzilla product