Closed Bug 475618 Opened 11 years ago Closed 11 years ago

xulrunner's platform.ini should include repo and sourcestamp

Categories

(Toolkit Graveyard :: XULRunner, defect, P2)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Pike, Assigned: Pike)

References

Details

(Keywords: fixed1.9.1, Whiteboard: [fennec l10n])

Attachments

(1 file, 1 obsolete file)

We should include the revision of the hg repo, and the repo url in xulrunner's platform.ini. We'll need that information to pick the right revision of that repo for l10n builds. And it's probably cool to have anyway.

We'll need this for proper fennec l10n, at least.
Whiteboard: [fennec l10n]
This follows the pattern we have in browser/app/Makefile.in, setting the SourceStamp and SourceRepository entries in platform.ini if we can deduce them from the source.
Assignee: nobody → l10n
Status: NEW → ASSIGNED
Attachment #359259 - Flags: review?(benjamin)
Attachment #359259 - Flags: review?(benjamin) → review+
Depends on: 475961
Updated the patch for landing with the extra goo we do in other places to catch some hg issues. Tested locally both with .hg in place and not.
Attachment #359259 - Attachment is obsolete: true
Attachment #362572 - Flags: review+
http://hg.mozilla.org/mozilla-central/rev/566e513f5bcd1391d227611dc19c2871818020a2, landed.

We should land this on 1.9.1, too. For one, mobile might move over to 1.9.1, too, and it will benefit the localization of the comm-central apps, too.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: blocking1.9.1?
Resolution: --- → FIXED
Attachment #362572 - Flags: approval1.9.1?
Yeah, let's call this a P2 blocker and get it landed on 191 asap, bitte!
Flags: blocking1.9.1? → blocking1.9.1+
Priority: -- → P2
Attachment #362572 - Flags: approval1.9.1?
I believe this fix has busted builds when doing an hg merge.  Opened bug 553776.
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.