475620 - Add revision and repository of mobile-browser to fennec's application.ini

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Axel Hecht [:Pike]]

We should have the URL and the changeset ID of the repo that we used to build fennec in its application.ini, similar to what we do for Firefox.

We'll need that information to do proper l10n.

This is a sibling of bug 475618, which is about getting the mozilla-central revision and url into platform.ini.

I wonder, what should about:buildconfig show for fennec? Right now, it seems to just show the toolkit page with its revision.

Comment 1

[Axel Hecht [:Pike]]

Attachment: get the repo and sourcestamp from the source, and feed it into application.ini

Not sure if this is more a Ted or a Benjamin bug to review.

This is mostly a copy and paste of what we do in Firefox, with the exception that I'm not using $(topsrcdir) to ident and showconfig, but $(srcdir)/..
I need to get the actual repo path, so just $(srcdir) doesn't work, at least not for the showconfig piece. I have chosen the $(srcdir)/.. over $(topsrcdir)/mobile just because I find that less hard-coding how the mobile repo is checked out into the central clone. But it's a small margin by which that is.

Comment 2

[Axel Hecht [:Pike]]

Comment on attachment 359267 [details] [diff] [review]
get the repo and sourcestamp from the source, and feed it into application.ini

One review is enough for this, cancelling the one on Ted.

Comment 3

[(not currently active) Ted Mielczarek]

You'll want to be careful about the version of hg available on the mobile tinderboxes. I hit a problem with that when I did the buildconfig patch, you might want to verify that your method matches what I wound up with in the end.

Comment 4

[Axel Hecht [:Pike]]

yac, bustage fix coming up :-(

Comment 5

[Axel Hecht [:Pike]]

Attachment: do what ted did in toolkit/content

Do like Ted said and did, up to the point of "ugh, we should rewrite this in python".

And have a not-so-ancient refplatform for mobile, too.

Comment 6

[(not currently active) Ted Mielczarek]

Comment on attachment 359516 [details] [diff] [review]
do what ted did in toolkit/content

Sorry, should have commented earlier, I just didn't get a chance to look at your patch.

Comment 7

[Axel Hecht [:Pike]]

Attachment: be more paranoid even

I looked at the build log, and it seems that SOURCE_STAMP wasn't given. The only difference I see is that I use ; to chain the commands, while toolkit uses &&. Do that as well.

Comment 8

[Axel Hecht [:Pike]]

This landed, http://hg.mozilla.org/mobile-browser/rev/598b57dc080d and http://hg.mozilla.org/mobile-browser/rev/f2dbd5fe2416, but isn't FIXED, as the tinderbox hg doesn't cooperate.

Filed bug 475961, which in fact blocks this bug from being able to be closed.

Comment 9

[Axel Hecht [:Pike]]

Attachment: duh, don't use topsrcdir, but srdir/..

Duh, when putting in the bustage fix for this, I changed $(srcdir)/.. to $(topsrcdir) accidently, undo that one.

Comment 10

[(not currently active) Ted Mielczarek]

Comment on attachment 361307 [details] [diff] [review]
duh, don't use topsrcdir, but srdir/..

Why $(srcdir)/.. ? hg should work fine from any dir in the repo.

Comment 11

[Axel Hecht [:Pike]]

http://hg.mozilla.org/mobile-browser/rev/121ad0a9d105a5a608540cc61685e71dda594622, landed.

The .. was there from the time when I did -R, which didn't like $(srcdir). I left it in, as it can only help perf when hg doesn't need to stat up the directory tree. Though, I guess it stats probably everything anyway to figure out if it needs to + the sourcestamp.

FIXED.