Closed Bug 475632 Opened 11 years ago Closed 11 years ago

properly update the clean fragment cache

Categories

(Toolkit :: Safe Browsing, defect, P2)

defect

Tracking

()

RESOLVED FIXED

People

(Reporter: dcamp, Assigned: dcamp)

Details

(Keywords: fixed1.9.1)

Attachments

(1 file, 1 obsolete file)

Attached patch fix (obsolete) — Splinter Review
The clean fragment cache in the classifier should update on every check, not just on insert.
Flags: blocking-firefox3.1?
Attachment #359156 - Flags: review?(tony)
Comment on attachment 359156 [details] [diff] [review]
fix

> # xpcshell tests
>-XPCSHELL_TESTS=unit
>+#XPCSHELL_TESTS=unit

Why is this being commented out?  Otherwise, looks good.
Attachment #359156 - Flags: review?(tony) → review+
Attached patch fixedSplinter Review
Oops, commented those out to run the other tests more quickly, new patch fixes that.
Attachment #359156 - Attachment is obsolete: true
Comment on attachment 359165 [details] [diff] [review]
fixed

looks good!
Attachment #359165 - Flags: review+
Attachment #359165 - Flags: approval1.9.1?
Flags: blocking-firefox3.1? → blocking-firefox3.1+
Priority: -- → P2
Comment on attachment 359165 [details] [diff] [review]
fixed

a191=beltzner
Attachment #359165 - Flags: approval1.9.1? → approval1.9.1+
Whiteboard: [needs landing]
http://hg.mozilla.org/mozilla-central/rev/1deb39d3c86e
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/bc19cd840f64
Status: NEW → RESOLVED
Closed: 11 years ago
Keywords: fixed1.9.1
Resolution: --- → FIXED
Whiteboard: [needs landing]
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.