475647 - Removing display:none <svg:marker> sometimes doesn't repaint

Status: RESOLVED WORKSFORME

(Core :: SVG, defect)

Description

[Jesse Ruderman]

Attachment: testcase

The testcase should appear green, but sometimes it appears red until I resize the Firefox window.

Comment 1

[Robert Longson [:longsonr]]

I suspect that what is happening is this.

We trigger a refresh when the content changes i.e. the display attribute is set.
The refresh triggers an async repaint and the race is on...

On the near side we have frame creation
On the stand side we have the async repaint.

The winner is indicated by red or green.

Not sure what the answer is though.

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

(In reply to comment #1)
> We trigger a refresh when the content changes i.e. the display attribute is
> set.

You mean through a mutation observer? The style can change without the style attribute changing, so it's worse than that.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: testcase #2

This testcase doesn't have a race, it just displays incorrectly.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

One option would be to set up some kind of hook so that when we construct frames for an element that we want to have nsSVGRenderingObservers on, we notify potential observers.

But ... according to the SVG spec, should we actually be displaying a marker even if it's display:none? I have a sinking feeling that we maybe we should.

Comment 5

[Robert Longson [:longsonr]]

(In reply to comment #4)
> 
> But ... according to the SVG spec, should we actually be displaying a marker
> even if it's display:none? I have a sinking feeling that we maybe we should.

indeed we're sunk by http://www.w3.org/TR/SVG11/painting.html#MarkerElement final paragraph and tracked by bug 376027

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

So we just need to fix 376027, however hard that may be, and that will fix this bug.

Comment 7

[Robert Longson [:longsonr]]

These testcases now display consistently correctly. Now sure why but marker implementation changed a lot around firefox 9.