Closed
Bug 475680
Opened 16 years ago
Closed 15 years ago
Using gcNumber in the cycle collector heuristics
Categories
(Core :: JavaScript Engine, enhancement)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
People
(Reporter: igor, Assigned: igor)
References
Details
(Keywords: fixed1.9.1)
Attachments
(1 file)
|
5.97 KB,
patch
|
igor
:
review+
|
Details | Diff | Splinter Review |
Currently the cycle collector heuristics in dom/src/base/nsJSEnvironment.cpp use own counter of the number of times the code runs JS_GC. But this counter can be rather off since it does not count the number of JS_GC runs when the latter is triggered on JSContext destruction. So the idea is to use JSRuntime.gcNumber exposed through JS_GetGCParameter API in bug 474801. This bug blocks bug 453432 since to implement that bug the code would delegate the responsibility to call JS_GC to the runtime.
|
Assignee | |
Comment 1•16 years ago
|
||
This implementation comes directly from the patch from the bug 474801 comment 6 - the landed patch for thast bug does not include it to minimize the risk of regressions.
Attachment #359245 -
Flags: review+
|
||
Comment 2•15 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/0c727ce8bb5f
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
||
Updated•15 years ago
|
Flags: in-testsuite-
Flags: in-litmus-
|
|
||
Comment 3•15 years ago
|
||
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/30045b44b85d
Flags: wanted1.9.1+
Keywords: fixed1.9.1
You need to log in
before you can comment on or make changes to this bug.
Description
•