475768 - [java backend] NPE in Register.login()

Status: RESOLVED WONTFIX

(Skywriter Graveyard :: Server, defect, P4)

Description

[Simon Kaegi]

User-Agent:       Mozilla/4.0 (compatible; MSIE 7.0; Windows NT 5.1; .NET CLR 2.0.50727; .NET CLR 3.0.04506.30; .NET CLR 1.1.4322; .NET CLR 3.0.04506.648)
Build Identifier: 

In the final block of login() we need to re-retrieve the session that was is newly created by storeLoggedInUser(result). If we don't we get an NPE when we call this.printUserJSON(session.username).

--

        // -- if you are already logged in return
        UserSession session = (UserSession) getCtx().getReq().getSession(true).getAttribute("userSession");
        if (session != null && session.username.equals(username)) {
            this.printUserJSON(session.username);
        } else {
            String result = getAuthenticator().authenticate(getCtx(), username, password);
            if (result != null) {
                storeLoggedInUser(result);
                // ADDED this line to avoid the NPE
                session = (UserSession) getCtx().getReq().getSession(true).getAttribute("userSession");
                this.printUserJSON(session.username);
            }
        }

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Gordon P. Hemsley [:GPHemsley]]

This is a mass migration from Mozilla Labs :: Bespin to Bespin :: Server.

Comment 2

[Ben Galbraith]

We won't be maintaining the java back-end for the foreseeable future