475802 - remove undiscoverable accesskeys in Library

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Simon Bünzli]

AFAICT backCmd.accesskey and forwardCmd.accesskey are not discoverable at all except if in a translation the same accesskey is used in a different place (e.g. in the German localization, see bug 475628).

And since bug 408663 was fixed, not even a11y is an argument to keep these...

Comment 1

[Simon Bünzli]

Attachment: remove the undiscoverable accesskeys

Comment 2

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Comment on attachment 359357 [details] [diff] [review]
remove the undiscoverable accesskeys

since this is a change in a behavior, forwarding to dietrich.

Comment 3

[Dietrich Ayala (:dietrich)]

Comment on attachment 359357 [details] [diff] [review]
remove the undiscoverable accesskeys

yeah this should be fine, r=me

Comment 4

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/9ab600c487a7

Comment 5

[Simon Bünzli]

Comment on attachment 359357 [details] [diff] [review]
remove the undiscoverable accesskeys

Approval requested only for the places.xul bits (no l10n change required).

Comment 6

[Tracy Walker [:tracy]]

verified per code check in

Comment 7

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 359357 [details] [diff] [review]
remove the undiscoverable accesskeys

Don't really see the advantage of taking the XUL only fix on branch.

Comment 8

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv