Closed Bug 475824 Opened 12 years ago Closed 12 years ago

preventive maintenance has low possibilites to be run

Categories

(Toolkit :: Places, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9.2a1

People

(Reporter: mak, Assigned: mak)

References

Details

(Keywords: fixed1.9.1)

Attachments

(1 file)

actually preventive maintenance is inited by nsIUpdateTimerManager, it looks every 30 minutes for an idle of 10 minutes.

Being inited by nsIUpdateTimerManager the check will run only once a day, if the session in which we check for idle does not lasts for hours, the possibilities it runs are really really low.

I'm not concerned about not running it every day, but current timers probably could cause it to never run for some user (think you every morning open Firefox for half an hour to check your mail, then close it, since the timer has already fired, next sessions won't check anymore).

i was thinking to check every 10 minutes for an idle of 5 minutes, after a run all timers will stop.
Target Milestone: --- → mozilla1.9.1
Depends on: 431558
Attached patch patch v1.0Splinter Review
Probably 5 minutes of idle are not enough, so for now i only reduced checks, so check every 10 minutes for an idle of 10 minutes... if the browsing session of the user where the timer fires lasts for at least one hour we will have 5 possibilities to run, against 2 we actually have.
Assignee: nobody → mak77
Status: NEW → ASSIGNED
Attachment #359830 - Flags: review?(dietrich)
Attachment #359830 - Flags: review?(dietrich) → review+
Comment on attachment 359830 [details] [diff] [review]
patch v1.0

sounds fine, r=me.
http://hg.mozilla.org/mozilla-central/rev/47c7a138b9da
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: mozilla1.9.1 → mozilla1.9.2a1
Attachment #359830 - Flags: approval1.9.1?
Comment on attachment 359830 [details] [diff] [review]
patch v1.0

asking approval 1.9.1, no risk, allows preventive maintenance to have some more possibility to be run.
Maybe not the right place to ask this, but are there any plans to allow maintenance to run on a computer that's in use without effecting performance too much? (by monitoring disk I/O and throttling maintenance as necessary - I assume it's already run at low CPU priority) This would be useful if Firefox hasn't had focus in a while, but the computer hasn't been idle. Presumably other less aggressive strategies are already employed while Firefox is being used.

My apologies if I'm way off base here and 'idle time' only applies to Firefox and not system-wide activity.
wanted imo, preventive strips away some work from expiration too, and puts that in a separate thread.
Flags: wanted1.9.1?
Comment on attachment 359830 [details] [diff] [review]
patch v1.0

a191=beltzner
Attachment #359830 - Flags: approval1.9.1? → approval1.9.1+
Flags: wanted1.9.1?
You need to log in before you can comment on or make changes to this bug.