Closed Bug 475834 Opened 14 years ago Closed 14 years ago

/**/ comments with newlines in them do not act as line breaks

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla1.9.2a1

People

(Reporter: brendan, Assigned: mrbkap)

References

Details

(Keywords: verified1.9.1, Whiteboard: fixed-in-tracemonkey)

Attachments

(3 files, 1 obsolete file)

js shell testcase
243 bytes, text/plain
Details
web page testcase
314 bytes, text/html
Details
Better [Checkin: Comment 8 & 9]
1.25 KB, patch
brendan
: review+
Details | Diff | Splinter Review 
This matters in automatic semicolon insertion in ES3. Doug Crockford pointed this out and said only Opera follows the spec. We should make the fix, as I doubt it will break anyone and it is easy -- and anyway the spec is better than the bug.

/be
Attached file js shell testcase —
Attached file web page testcase —
Attached patch So, comme ça? (obsolete) — — Splinter Review 
This was the most obvious way to do it.
Assignee: general → mrbkap
Status: NEW → ASSIGNED
Attachment #359410 - Flags: review?(brendan)
Attachment #359410 - Attachment is obsolete: true
Attachment #359481 - Flags: review?(brendan)
Attachment #359410 - Flags: review?(brendan)
Attachment #359481 - Flags: review?(brendan) → review+
Safe ride-along for 3.1, gets us right with jslint and other analyzers.

/be
Flags: wanted1.9.1?
Comment on attachment 359481 [details] [diff] [review]
Better
[Checkin: Comment 8 & 9]

Shouldn't need much baking -- pls. get it into tm and m-c asap.

/be
Attachment #359481 - Flags: approval1.9.1?
http://hg.mozilla.org/mozilla-central/rev/b224b8b053ff
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Flags: wanted1.9.1? → wanted1.9.1+
Resolution: --- → FIXED
This seems well-baked for 1.9.1.

/be
Keywords: checkin-needed
Attachment #359481 - Attachment description: Better → Better [Checkin: Comment 8 & 9]
Needs approval1.9.1 before checkin-needed.
Keywords: checkin-needed
Whiteboard: fixed-in-tracemonkey → [needs 1.9.1 landing] fixed-in-tracemonkey
Target Milestone: --- → mozilla1.9.2a1
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/8505aceecbb4
Keywords: fixed1.9.1
Whiteboard: [needs 1.9.1 landing] fixed-in-tracemonkey → fixed-in-tracemonkey
v 1.9.1, 1.9.1-tm, 1.9.2
Status: RESOLVED → VERIFIED
Keywords: fixed1.9.1 → verified1.9.1
Attachment #359481 - Flags: approval1.9.1?
You need to log in before you can comment on or make changes to this bug.