/**/ comments with newlines in them do not act as line breaks

VERIFIED FIXED in mozilla1.9.2a1

Status

()

Core
JavaScript Engine
VERIFIED FIXED
8 years ago
6 years ago

People

(Reporter: brendan, Assigned: mrbkap)

Tracking

({verified1.9.1})

Trunk
mozilla1.9.2a1
verified1.9.1
Points:
---
Bug Flags:
wanted1.9.1 +
in-testsuite +
in-litmus -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(3 attachments, 1 obsolete attachment)

(Reporter)

Description

8 years ago
This matters in automatic semicolon insertion in ES3. Doug Crockford pointed this out and said only Opera follows the spec. We should make the fix, as I doubt it will break anyone and it is easy -- and anyway the spec is better than the bug.

/be
(Reporter)

Comment 1

8 years ago
Created attachment 359405 [details]
js shell testcase
(Reporter)

Comment 2

8 years ago
Created attachment 359407 [details]
web page testcase
(Assignee)

Comment 3

8 years ago
Created attachment 359410 [details] [diff] [review]
So, comme ça?

This was the most obvious way to do it.
Assignee: general → mrbkap
Status: NEW → ASSIGNED
Attachment #359410 - Flags: review?(brendan)
(Assignee)

Comment 4

8 years ago
Created attachment 359481 [details] [diff] [review]
Better
[Checkin: Comment 8 & 9]
Attachment #359410 - Attachment is obsolete: true
Attachment #359481 - Flags: review?(brendan)
Attachment #359410 - Flags: review?(brendan)

Updated

8 years ago
Duplicate of this bug: 475884
(Reporter)

Updated

8 years ago
Attachment #359481 - Flags: review?(brendan) → review+
(Reporter)

Comment 6

8 years ago
Safe ride-along for 3.1, gets us right with jslint and other analyzers.

/be
Flags: wanted1.9.1?
(Reporter)

Comment 7

8 years ago
Comment on attachment 359481 [details] [diff] [review]
Better
[Checkin: Comment 8 & 9]

Shouldn't need much baking -- pls. get it into tm and m-c asap.

/be
Attachment #359481 - Flags: approval1.9.1?
(Assignee)

Comment 8

8 years ago
http://hg.mozilla.org/tracemonkey/rev/b224b8b053ff
Whiteboard: fixed-in-tracemonkey

Comment 9

8 years ago
http://hg.mozilla.org/mozilla-central/rev/b224b8b053ff
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Flags: wanted1.9.1? → wanted1.9.1+
Resolution: --- → FIXED
(Reporter)

Comment 10

8 years ago
This seems well-baked for 1.9.1.

/be
Keywords: checkin-needed
Attachment #359481 - Attachment description: Better → Better [Checkin: Comment 8 & 9]
Needs approval1.9.1 before checkin-needed.
Keywords: checkin-needed
Whiteboard: fixed-in-tracemonkey → [needs 1.9.1 landing] fixed-in-tracemonkey
Target Milestone: --- → mozilla1.9.2a1

Comment 12

8 years ago
http://hg.mozilla.org/mozilla-central/rev/bc425645f2cf
Flags: in-testsuite+
Flags: in-litmus-

Comment 13

8 years ago
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/8505aceecbb4
Keywords: fixed1.9.1
Whiteboard: [needs 1.9.1 landing] fixed-in-tracemonkey → fixed-in-tracemonkey

Comment 14

8 years ago
v 1.9.1, 1.9.1-tm, 1.9.2
Status: RESOLVED → VERIFIED
Keywords: fixed1.9.1 → verified1.9.1
Attachment #359481 - Flags: approval1.9.1?
(Reporter)

Updated

6 years ago
Duplicate of this bug: 397104
You need to log in before you can comment on or make changes to this bug.