ImtBuilder::finish doesn't need to do anything when MIR is disabled at runtime

VERIFIED FIXED

Status

Tamarin
Virtual Machine
VERIFIED FIXED
9 years ago
9 years ago

People

(Reporter: Steven Johnson, Unassigned)

Tracking

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

9 years ago
Created attachment 359402 [details] [diff] [review]
Patch
Attachment #359402 - Flags: review?(edwsmith)

Updated

9 years ago
Attachment #359402 - Flags: review?(edwsmith) → review-

Comment 1

9 years ago
Comment on attachment 359402 [details] [diff] [review]
Patch

Traits::resolveSignatures() does not call ImtBuilder::finish if !IsMIREnabled().
(Reporter)

Comment 2

9 years ago
You're right. It should be an assert instead.
(Reporter)

Comment 3

9 years ago
Created attachment 359564 [details] [diff] [review]
Patch #2 -- change check to assertion
Attachment #359402 - Attachment is obsolete: true
Attachment #359564 - Flags: review?(edwsmith)

Comment 4

9 years ago
Comment on attachment 359564 [details] [diff] [review]
Patch #2 -- change check to assertion

looks fine, but how did you ever manage to hit that case?
Attachment #359564 - Flags: review?(edwsmith) → review+
(Reporter)

Comment 5

9 years ago
I think it's a holdover from when the caller didn't check... the test here was inserted (in a different branch) and I didn't check appropriately before offering this bit for merging. it's probably redundant but assertions are cheap...
(Reporter)

Comment 6

9 years ago
changeset:   1368:3013f72b8503
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → INVALID
(Reporter)

Updated

9 years ago
Resolution: INVALID → FIXED

Updated

9 years ago
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.